Added hysteresis to length, clickable "…more" #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some hysteresis to the cutoff length to avoid the situation where a block of text that is one word longer than the cutoff gets truncated. By making the cutoff say, 1.5 times the length of the final text you can only truncate text that is significantly longer than the cutoff. So if your length is 60 you'll end up with text from 60-90 chars in length, and any that are over 90 get truncated to 60. This gives a much more pleasing result.
Example, using the three sentence below:
source
default way
my way
Also I added a clickable …more tag at the truncation point, that toggles the visibility of the truncated text. This is a bit^h^h^h^h totally kludgy, I'm not a web designer, but it works for my use.