Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki page of Test models has unwanted text output #984

Closed
Jingru923 opened this issue Jan 24, 2024 · 1 comment · Fixed by #1396
Closed

Wiki page of Test models has unwanted text output #984

Jingru923 opened this issue Jan 24, 2024 · 1 comment · Fixed by #1396
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Jingru923
Copy link
Contributor

In the page, there were supposed to be only brief introductions and graphs of the test models. Since we updated Pandas, many text messages have been generated.

/home/runner/work/Ribasim/Ribasim/.pixi/env/lib/python3.11/site-packages/pandera/backends/pandas/array.py:336: FutureWarning:

A value is trying to be set on a copy of a DataFrame or Series through chained assignment using an inplace method.
The behavior will change in pandas 3.0. This inplace method will never work because the intermediate object on which we are setting values always behaves as a copy.

For example, when doing 'df[col].method(value, inplace=True)', try using 'df.method({col: value}, inplace=True)' or df[col] = df[col].method(value) instead, to perform the operation inplace on the original object.

As this text is not wanted, we should go to the source (Ribasim Python) where these warning texts are from and fix the problem.

@Jingru923 Jingru923 added the documentation Improvements or additions to documentation label Jan 24, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Jan 24, 2024
@Jingru923 Jingru923 moved this from To do to What's next in Ribasim Jan 25, 2024
@Jingru923 Jingru923 moved this from What's next to 🏗 In progress in Ribasim Jan 25, 2024
@visr
Copy link
Member

visr commented Jan 25, 2024

The warning mentioned in this issue comes from pandera, and there is an open pull request to fix it: unionai-oss/pandera#1464. We could keep an older pandas in our pixi file to clear the docs, but this would not stop users from getting the warning.

@visr visr moved this from 🏗 In progress to Paused in Ribasim Jan 25, 2024
visr added a commit that referenced this issue Jan 25, 2024
Addresses part of #984, at least for our dev environment. I'm keeping
#984 open to remind us to unpin it when a new pandera is out.

This also adds [xugrid](https://github.com/Deltares/xugrid) and netCDF4
to our pixi environment. Not as a ribasim dependency, but will need it
to run conversion scripts from #969.
Hofer-Julian added a commit that referenced this issue Apr 16, 2024
evetion pushed a commit that referenced this issue Apr 16, 2024
@github-project-automation github-project-automation bot moved this from Paused to ✅ Done in Ribasim Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants