Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS settings #738

Open
d-perl opened this issue Nov 29, 2024 · 0 comments
Open

Add CORS settings #738

d-perl opened this issue Nov 29, 2024 · 0 comments
Labels
enhancement New feature or request rest api Potential REST API changes
Milestone
1.0.0

Comments

@d-perl
Copy link
Contributor

d-perl commented Nov 29, 2024

When talking to the REST API from a local JS application, Firefox blocks the requests from 127.0.0.1 unless they are returned with an appropriate CORS header

Acceptance Criteria

  • Some flag or config variable allows setting allowed origins and adding the CORSMiddleware to the fastAPI app, including an option for allowing all origins for testing
@callumforrester callumforrester added enhancement New feature or request rest api Potential REST API changes labels Nov 29, 2024
@callumforrester callumforrester added this to the 1.0.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request rest api Potential REST API changes
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@callumforrester @d-perl