Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header byte 0xA3 reported as power event #1

Open
cpm64 opened this issue May 3, 2023 · 0 comments
Open

Header byte 0xA3 reported as power event #1

cpm64 opened this issue May 3, 2023 · 0 comments

Comments

@cpm64
Copy link

cpm64 commented May 3, 2023

Hello,

I wonder if this is done on purpose or could be my wrong understanding of the specs:

XpressNet.cpp @411

			if (XNetMsg[XNetlength] >= 4) {
				if (notifyXNetPower)
					notifyXNetPower(XNetMsg[XNetdata1]);
			}

As described in Xpressnet spec 2003 EN version: 0xA3 is reporting a short-addr lok (non v3 protocol):
"Locomotive is being operated by another device
P+0x60+GA 0xA3 addr data1 data2"

In my understanding, reporting this as a power event is kinda misleading.

Offtopic: For my personal needs, I forked and introduced a new event: notifyLokBusy for 0xA3 and also for 0xE3 just after line 396.

Cheers,
CPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant