Attempt to call NULL function

[cpm64]

Hi,

It seems there is a problem in XNetMaster.cpp @ 546, there is no NULL check before calling notifyXNetFeedback:

for (byte i = 1; i <= len; i++) {
   notifyXNetFeedback((XNetRXBuffer.msg[XNetRXBuffer.get].data[XNetheader+(i*2)-1] << 2) | ((XNetRXBuffer.msg[XNetRXBuffer.get].data[XNetheader+(i*2)] & B110) >> 1), XNetRXBuffer.msg[XNetRXBuffer.get].data[XNetheader+(i*2)]);
}

Everything is fine if the notify is defined, however if not defined it will crash.

Possible fix:

if(notifyXNetFeedback){
  for (byte i = 1; i <= len; i++) {
    notifyXNetFeedback((XNetRXBuffer.msg[XNetRXBuffer.get].data[XNetheader+(i*2)-1] << 2) | ((XNetRXBuffer.msg[XNetRXBuffer.get].data[XNetheader+(i*2)] & B110) >> 1), XNetRXBuffer.msg[XNetRXBuffer.get].data[XNetheader+(i*2)]);
  }
}

Cheers,
CPM

[Digital-MoBa]

Fix implementet with v4.1.0