-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon list changed with link #225 #6664
Open
MadhaviMandalia
wants to merge
245
commits into
Dogfalo:v1-dev
Choose a base branch
from
MadhaviMandalia:main
base: v1-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Weil <[email protected]>
Update the organization name
…erTrigger-false fix dropdown position when coverTrigger is false
Fix disabled checked switch style
Upgrade waves
…rt of the code fixes this commit applies this review comment : materializecss#187 (comment)
…dropdown changed all occurences of 1.1.0 to 1.0.0, then added a 1.0.0 link option than points to the official docs, and edited the 0.100.0 docs links to use https instead of http fix #179
…as the v1-upgrade-guide.md file Since it's no longer needed. 0.100.2 is very very old.
- moved from `bower:materialize` to `yarn:@materializecss/materialize` - removed Meteor and Ember packages (since they are using 0.100)
…have been removed from the docs fix #178
fix(issue180): handling invalid clickedIndex in carousel.js
…de-guide Since there are still many projects which use the original version and some 0.x release, it has been decided to not delete the v1-upgrade-guide.md file
docs(getting_started): update the ways to install materialize
fix: Waves concat order
I'm still wondering why the font section have been deleted... See : https://git.io/JK9is Closes #175
I'm removing the most of the section about the Roboto Font by just keeping the "how to change the font stack" part. Fixes #175
…t stack" this applies the suggested changed of this review : materializecss#212 (comment)
Fix #175 : Add a docs section on how to change the font stack
…sion, and minor changes - Added the community as part of the team, by explaining why we forked the repo and by adding a dynamic image that show the top 24 contributors. Prob is that it don't sort by team members but rather by commit numbers - Added a message in the index page that says this version is a fork - Changeed the catchphrase in the homepage - Rephrased a sentence inside the introduction grid shown in the homepage and grid section fix #194
…load a dynamic select component fix #171
docs: rework about and home page to mention this is the community fork
docs(select): rephrase a sentence in select docs, issue 171
mehidou
reviewed
Feb 15, 2022
if (!!iconUrl) { | ||
let imgEl = $(`<img alt="" src="${iconUrl}">`); | ||
let imgEl = $(`<img alt="" class="${classes}" src="${iconUrl}">`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className instead i think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removed icon list from the page and change the text with the relevant link which is
Search Google's Icons
Screenshots:
Marked text and links are changed as specified in materializecss#225
Types of changes
Checklist: