Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use with private doc pages #72

Open
sstrong99 opened this issue Sep 29, 2023 · 3 comments
Open

use with private doc pages #72

sstrong99 opened this issue Sep 29, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@sstrong99
Copy link

Is it possible to use this extension with private doc pages that require login?
@DriesSchaumont
Copy link
Owner

Hi @sstrong99,

I don't think so. Currently, an request is made to get the master project here:

sphinx-subprojecttoctree/subprojecttoctree/__init__.py

Line 105 in 4686bf7

response = requests.get(toctree_source_url)

This is a request that does not include authentication. Unfortunatly, I am not able to test or easily implement this feature because I do not have a readthedocs subscription. I would be happy to accept a pull request, though.

@DriesSchaumont DriesSchaumont added the enhancement New feature or request label Oct 7, 2023
@sstrong99
Copy link
Author

ok, thanks for the response. i may be able to make a PR at some point

@sstrong99
Copy link
Author

PR here: #73

see the caveat in the description there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DriesSchaumont @sstrong99