Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android onError is not called when uri is empty or null #1028

Open
alex-amaral opened this issue Mar 1, 2024 · 1 comment
Open

Android onError is not called when uri is empty or null #1028

alex-amaral opened this issue Mar 1, 2024 · 1 comment
Labels

Comments

@alex-amaral
Copy link

Describe the bug
When uri is empty or null it doesn't fire onError callback for Android.

To Reproduce
Steps to reproduce the behavior if possible, or a link to a reproduction repo:

  1. Pass an image with source.uri as an empty string
  2. Put a console.log on onError callback of FastImage
  3. See the log is not dispatched

Expected behavior
Passing an empty string or a null string as a source uri should fail the image load and React Native should be notified about that. This works properly on iOS

Dependency versions

  • React Native version: 0.72.8
  • React version: 18.2.0
  • React Native Fast Image version: 8.6.3

Note: if these are not the latest versions of each I recommend updating as extra effort will not be taken to be backwards compatible, and updating might resolving your issue.

@alex-amaral alex-amaral added the bug label Mar 1, 2024
mistryswapnil-dream11 added a commit to dream11/react-native-fast-image that referenced this issue Jun 11, 2024
@deepanshushuklad11
Copy link

This issue has been fixed in @d11/react-native-fast-image
Dream11 has forked this repo and created new package .
Dream11 is actively maintaining this new package and will be fixing relevant and reproducible issues of this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants