You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When uri is empty or null it doesn't fire onError callback for Android.
To Reproduce
Steps to reproduce the behavior if possible, or a link to a reproduction repo:
Pass an image with source.uri as an empty string
Put a console.log on onError callback of FastImage
See the log is not dispatched
Expected behavior
Passing an empty string or a null string as a source uri should fail the image load and React Native should be notified about that. This works properly on iOS
Dependency versions
React Native version: 0.72.8
React version: 18.2.0
React Native Fast Image version: 8.6.3
Note: if these are not the latest versions of each I recommend updating as extra effort will not be taken to be backwards compatible, and updating might resolving your issue.
The text was updated successfully, but these errors were encountered:
This issue has been fixed in @d11/react-native-fast-image
Dream11 has forked this repo and created new package .
Dream11 is actively maintaining this new package and will be fixing relevant and reproducible issues of this repository.
Describe the bug
When uri is empty or null it doesn't fire
onError
callback for Android.To Reproduce
Steps to reproduce the behavior if possible, or a link to a reproduction repo:
source.uri
as an empty stringconsole.log
ononError
callback of FastImageExpected behavior
Passing an empty string or a null string as a source uri should fail the image load and React Native should be notified about that. This works properly on iOS
Dependency versions
Note: if these are not the latest versions of each I recommend updating as extra effort will not be taken to be backwards compatible, and updating might resolving your issue.
The text was updated successfully, but these errors were encountered: