[Error: cannot inherit from final ImageSource] after update react-native to 0.75.1 #1043

YuriOlepir · 2024-08-15T15:40:21Z

Hello, i updated react-native to the latest 0.75.1 version and now have got such errors after executing run android command.

/app/node_modules/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java:14: error: cannot inherit from final ImageSource
public class FastImageSource extends ImageSource { ^
/app/node_modules/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java:72: error: isResource() in FastImageSource cannot override isResource() in ImageSource public boolean isResource() { ^ overridden method is final
/app/node_modules/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java:101: error: getUri() in FastImageSource cannot override getUri() in ImageSource public Uri getUri() { ^ overridden method is final

The text was updated successfully, but these errors were encountered:

ahmaddehnavi · 2024-08-15T23:19:25Z

Same here

Koykoy200078 · 2024-08-16T01:12:40Z

same issue

divyangkhatri · 2024-08-16T10:54:35Z

same here

ramonxm · 2024-08-16T17:19:47Z

same here, any solutions?

aviral1518 · 2024-08-16T20:00:05Z

same here, any solutions?

Boscotec · 2024-08-17T11:03:16Z

Temporary Workaround.

You can try modifying the library code until the library is officially updated.

Open the file causing issues: /node_modules/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java.

Replace the code with the one below.

package com.dylanvann.fastimage;

import android.content.Context;
import android.content.res.Resources;
import android.net.Uri;
import android.text.TextUtils;

import com.bumptech.glide.load.model.GlideUrl;
import com.bumptech.glide.load.model.Headers;
import com.facebook.react.views.imagehelper.ImageSource;

import javax.annotation.Nullable;

public class FastImageSource {
    private static final String DATA_SCHEME = "data";
    private static final String LOCAL_RESOURCE_SCHEME = "res";
    private static final String ANDROID_RESOURCE_SCHEME = "android.resource";
    private static final String ANDROID_CONTENT_SCHEME = "content";
    private static final String LOCAL_FILE_SCHEME = "file";
    private final Headers mHeaders;
    private Uri mUri;
    private final ImageSource imageSource; // Composition instead of inheritance

    public static boolean isBase64Uri(Uri uri) {
        return DATA_SCHEME.equals(uri.getScheme());
    }

    public static boolean isLocalResourceUri(Uri uri) {
        return LOCAL_RESOURCE_SCHEME.equals(uri.getScheme());
    }

    public static boolean isResourceUri(Uri uri) {
        return ANDROID_RESOURCE_SCHEME.equals(uri.getScheme());
    }

    public static boolean isContentUri(Uri uri) {
        return ANDROID_CONTENT_SCHEME.equals(uri.getScheme());
    }

    public static boolean isLocalFileUri(Uri uri) {
        return LOCAL_FILE_SCHEME.equals(uri.getScheme());
    }

    public FastImageSource(Context context, String source) {
        this(context, source, null);
    }

    public FastImageSource(Context context, String source, @Nullable Headers headers) {
        this(context, source, 0.0d, 0.0d, headers);
    }

    public FastImageSource(Context context, String source, double width, double height, @Nullable Headers headers) {
        imageSource = new ImageSource(context, source, width, height); // Create ImageSource instance
        mHeaders = headers == null ? Headers.DEFAULT : headers;
        mUri = imageSource.getUri(); // Get URI from ImageSource

        if (isResource() && TextUtils.isEmpty(mUri.toString())) {
            throw new Resources.NotFoundException("Local Resource Not Found. Resource: '" + getSource() + "'.");
        }

        if (isLocalResourceUri(mUri)) {
            // Convert res:/ scheme to android.resource:// so
            // Glide can understand the URI.
            mUri = Uri.parse(mUri.toString().replace("res:/", ANDROID_RESOURCE_SCHEME + "://" + context.getPackageName() + "/"));
        }
    }

    public boolean isBase64Resource() {
        return mUri != null && FastImageSource.isBase64Uri(mUri);
    }

    public boolean isResource() {
        return mUri != null && FastImageSource.isResourceUri(mUri);
    }

    public boolean isLocalFile() {
        return mUri != null && FastImageSource.isLocalFileUri(mUri);
    }

    public boolean isContentUri() {
        return mUri != null && FastImageSource.isContentUri(mUri);
    }

    public Object getSourceForLoad() {
        if (isContentUri()) {
            return getSource();
        }
        if (isBase64Resource()) {
            return getSource();
        }
        if (isResource()) {
            return getUri();
        }
        if (isLocalFile()) {
            return getUri().toString();
        }
        return getGlideUrl();
    }

    public Uri getUri() {
        return mUri;
    }

    public Headers getHeaders() {
        return mHeaders;
    }

    public GlideUrl getGlideUrl() {
        return new GlideUrl(getUri().toString(), getHeaders());
    }

    public String getSource() {
        return imageSource.getSource(); // Delegate to ImageSource
    }
}

Finally you can use patch package (https://github.com/ds300/patch-package) to patch it.

deepanshushuklad11 · 2024-08-17T19:27:36Z

Hello use https://www.npmjs.com/package/@d11/react-native-fast-image
It is actively maintained and issue will be resolved soon

hpanwar521 · 2024-08-18T20:38:55Z

I am also getting the same issue, i am using latest 0.75.1 version of react native library

aviral1518 · 2024-08-18T20:49:40Z

Temporary Workaround.

You can try modifying the library code until the library is officially updated.

Open the file causing issues: /node_modules/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java.

Replace the code with the one below.

package com.dylanvann.fastimage;

import android.content.Context;
import android.content.res.Resources;
import android.net.Uri;
import android.text.TextUtils;

import com.bumptech.glide.load.model.GlideUrl;
import com.bumptech.glide.load.model.Headers;
import com.facebook.react.views.imagehelper.ImageSource;

import javax.annotation.Nullable;

public class FastImageSource {
    private static final String DATA_SCHEME = "data";
    private static final String LOCAL_RESOURCE_SCHEME = "res";
    private static final String ANDROID_RESOURCE_SCHEME = "android.resource";
    private static final String ANDROID_CONTENT_SCHEME = "content";
    private static final String LOCAL_FILE_SCHEME = "file";
    private final Headers mHeaders;
    private Uri mUri;
    private final ImageSource imageSource; // Composition instead of inheritance

    public static boolean isBase64Uri(Uri uri) {
        return DATA_SCHEME.equals(uri.getScheme());
    }

    public static boolean isLocalResourceUri(Uri uri) {
        return LOCAL_RESOURCE_SCHEME.equals(uri.getScheme());
    }

    public static boolean isResourceUri(Uri uri) {
        return ANDROID_RESOURCE_SCHEME.equals(uri.getScheme());
    }

    public static boolean isContentUri(Uri uri) {
        return ANDROID_CONTENT_SCHEME.equals(uri.getScheme());
    }

    public static boolean isLocalFileUri(Uri uri) {
        return LOCAL_FILE_SCHEME.equals(uri.getScheme());
    }

    public FastImageSource(Context context, String source) {
        this(context, source, null);
    }

    public FastImageSource(Context context, String source, @Nullable Headers headers) {
        this(context, source, 0.0d, 0.0d, headers);
    }

    public FastImageSource(Context context, String source, double width, double height, @Nullable Headers headers) {
        imageSource = new ImageSource(context, source, width, height); // Create ImageSource instance
        mHeaders = headers == null ? Headers.DEFAULT : headers;
        mUri = imageSource.getUri(); // Get URI from ImageSource

        if (isResource() && TextUtils.isEmpty(mUri.toString())) {
            throw new Resources.NotFoundException("Local Resource Not Found. Resource: '" + getSource() + "'.");
        }

        if (isLocalResourceUri(mUri)) {
            // Convert res:/ scheme to android.resource:// so
            // Glide can understand the URI.
            mUri = Uri.parse(mUri.toString().replace("res:/", ANDROID_RESOURCE_SCHEME + "://" + context.getPackageName() + "/"));
        }
    }

    public boolean isBase64Resource() {
        return mUri != null && FastImageSource.isBase64Uri(mUri);
    }

    public boolean isResource() {
        return mUri != null && FastImageSource.isResourceUri(mUri);
    }

    public boolean isLocalFile() {
        return mUri != null && FastImageSource.isLocalFileUri(mUri);
    }

    public boolean isContentUri() {
        return mUri != null && FastImageSource.isContentUri(mUri);
    }

    public Object getSourceForLoad() {
        if (isContentUri()) {
            return getSource();
        }
        if (isBase64Resource()) {
            return getSource();
        }
        if (isResource()) {
            return getUri();
        }
        if (isLocalFile()) {
            return getUri().toString();
        }
        return getGlideUrl();
    }

    public Uri getUri() {
        return mUri;
    }

    public Headers getHeaders() {
        return mHeaders;
    }

    public GlideUrl getGlideUrl() {
        return new GlideUrl(getUri().toString(), getHeaders());
    }

    public String getSource() {
        return imageSource.getSource(); // Delegate to ImageSource
    }
}

Finally you can use patch package (https://github.com/ds300/patch-package) to patch it.

@hpanwar521 try this solution. It will work.

hpanwar521 · 2024-08-19T06:10:28Z

This is also not working for me ... is there any other solution

mohsenfl2022 · 2024-08-19T06:39:50Z

I am also getting the same issue. I am using the latest 0.75.1 version of the React Native library. Please heeeeeeeeeeeeeelp!

DylanVann#1043 (comment)

aviral1518 · 2024-08-19T08:49:11Z

I am also getting the same issue. I am using the latest 0.75.1 version of the React Native library. Please heeeeeeeeeeeeeelp!

@mohsenfl2022 follow these steps:-

Put the attached patch file inside the patches folder. If there is no patches folder, create one and put that file

Install patch-package.
After installation, run npx patch-package react-native-fast-image.

After that try building the app. It will work fine

react-native-fast-image+8.6.3.patch

DylanVann#1043 (comment)

NensiKasundra · 2024-08-20T06:20:55Z

facing the same issue with react-native 0.75.1 version while running the application in android.

node_modules/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java:14: error: cannot inherit from final ImageSource
public class FastImageSource extends ImageSource {
^

@DylanVann Kindly look into this

deepanshushuklad11 · 2024-08-20T06:28:32Z

This is fixed in https://github.com/facebook/react-native/pull/46092/files
You can also try @d11/react-native-fast-image

NensiKasundra · 2024-08-20T06:41:59Z

it's a fork of this. can we upgrade this in the same?

deepanshushuklad11 · 2024-08-20T07:03:33Z

it's a fork of this. can we upgrade this in the same?

react-native is the peer dependency of react-native-fast-image. So when you upgrade your app to the fixed version of react-native , it will automatically work

NensiKasundra · 2024-08-20T09:07:36Z

Here are the versions of libs. still, it's not working.

    "react": "18.3.1",
    "react-native": "0.75.1",
    "react-native-fast-image": "^8.6.3",

ramonxm · 2024-08-20T18:43:00Z

0.75.2 is fixed this issues

not fixed for me

NensiKasundra · 2024-08-21T06:09:52Z

it's not working with 0.75.2 also

NensiKasundra · 2024-08-21T06:21:48Z

Getting below errors with 0.75.2 version

/node_modules/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java:72: error: isResource() in FastImageSource cannot override isResource() in ImageSource
public boolean isResource() {
^
overridden method is final

/node_modules/react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageSource.java:101: error: getUri() in FastImageSource cannot override getUri() in ImageSource
public Uri getUri() {
^
overridden method is final

hamdij0maa · 2024-08-22T09:00:36Z

+1

gonzalorocha · 2024-08-22T12:37:58Z

+1

Kolahzary · 2024-08-22T13:34:49Z

This PR on react-native will solve this issue:

fix(android): make getUri and isResource available for override facebook/react-native#46152

SpawN005 · 2024-08-22T13:38:42Z

+1

liptonzuma · 2024-08-22T16:53:53Z

Any progress on this fam

kodeandoec · 2024-08-22T21:27:41Z

Someone have a solution for this issue, can someone contact with the repo owner?

kodeandoec · 2024-08-25T21:07:06Z

There's also a new alternative, Faster Image, https://github.com/candlefinance/faster-image

Hao-yiwen · 2024-08-28T18:20:54Z

same question.Hope fix this error coming soon.

lukedanielson · 2024-08-28T19:37:42Z

I've setup a patch file for this issue for version 0.75.2 in ./patches/react-native+0.75.2.patch

diff --git a/node_modules/react-native/ReactAndroid/api/ReactAndroid.api b/node_modules/react-native/ReactAndroid/api/ReactAndroid.api
index e647de2..6a14ffd 100644
--- a/node_modules/react-native/ReactAndroid/api/ReactAndroid.api
+++ b/node_modules/react-native/ReactAndroid/api/ReactAndroid.api
@@ -6459,9 +6459,9 @@ public class com/facebook/react/views/imagehelper/ImageSource {
 	public final fun getSize ()D
 	public final fun getSource ()Ljava/lang/String;
 	public static final fun getTransparentBitmapImageSource (Landroid/content/Context;)Lcom/facebook/react/views/imagehelper/ImageSource;
-	public final fun getUri ()Landroid/net/Uri;
+	public fun getUri ()Landroid/net/Uri;
 	public fun hashCode ()I
-	public final fun isResource ()Z
+	public fun isResource ()Z
 }
 
 public final class com/facebook/react/views/imagehelper/ImageSource$Companion {
diff --git a/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/imagehelper/ImageSource.kt b/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/imagehelper/ImageSource.kt
index 583b4a0..947044c 100644
--- a/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/imagehelper/ImageSource.kt
+++ b/node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/imagehelper/ImageSource.kt
@@ -23,12 +23,14 @@ constructor(
 ) {
 
   /** Get the URI for this image - can be either a parsed network URI or a resource URI. */
-  public val uri: Uri = computeUri(context)
+  public open val uri: Uri = computeUri(context)
   /** Get the area of this image. */
   public val size: Double = width * height
   /** Get whether this image source represents an Android resource or a network URI. */
-  public var isResource: Boolean = false
-    private set
+  public open val isResource: Boolean
+    get() = _isResource
+
+  private var _isResource: Boolean = false
 
   override fun equals(other: Any?): Boolean {
     if (this === other) {
@@ -58,7 +60,7 @@ constructor(
       }
 
   private fun computeLocalUri(context: Context): Uri {
-    isResource = true
+    _isResource = true
     return ResourceDrawableIdHelper.instance.getResourceDrawableUri(context, source)
   }

However the same build error happens after:

rm -Rf node_modules/
npm install
cd android && ./gradlew clean && cd ../
watchman watch-del all
npm run start --reset-cache

Is it possible to patch this?

Thioby · 2024-09-02T09:11:00Z

Hello use https://www.npmjs.com/package/@d11/react-native-fast-image It is actively maintained and issue will be resolved soon

does not work.

deepanshushuklad11 · 2024-09-02T10:23:26Z

Hello use https://www.npmjs.com/package/@d11/react-native-fast-image It is actively maintained and issue will be resolved soon

does not work.

It will be fixed in [email protected]

JohnSmall · 2024-09-04T15:40:31Z

Any idea when [email protected] will be released?

JohnSmall · 2024-09-04T15:50:42Z

https://www.npmjs.com/package/@d11/react-native-fast-image

Yup, I can confirm that the above repo does not fix the problem. Even though the most recent release was less than 24 hours ago.

deepanshushuklad11 · 2024-09-05T05:00:21Z

https://www.npmjs.com/package/@d11/react-native-fast-image

Yup, I can confirm that the above repo does not fix the problem. Even though the most recent release was less than 24 hours ago.

@JohnSmall The issue has been fixed in react-native. Once they release new version it will automatically gets fixed in fast image.
Currently i am triggering a cron based nightly build for everyone to see whats coming. That is reason last publish is less than 24 hours ago.
I am working on nightly build optimisation.In future this will be triggered only if changes are there.
Let me know if you have more concerns i am happy to help.

deepanshushuklad11 · 2024-09-10T09:59:26Z

@YuriOlepir Issue has been fixed in @d11/react-native-fast-image

Gautham495 · 2024-09-26T06:24:08Z

@deepanshushuklad11 can we use your library in 73.8 version. Please provide some social media links so I can DM you there.

deepanshushuklad11 · 2024-09-26T07:41:34Z

@deepanshushuklad11 can we use your library in 73.8 version. Please provide some social media links so I can DM you there.

@Gautham495 it should work , latest version is using fabric renderer too.
Connect with me on linkedin https://www.linkedin.com/in/deepanshu-s-48227062/

Gautham495 · 2024-09-26T07:45:16Z

@deepanshushuklad11 Sent a connection request.

lucianolopezz · 2024-10-22T19:34:32Z

Updated react-native to 0.75.4, worked for me!

YuriOlepir added the bug label Aug 15, 2024

YuriOlepir changed the title ~~Error: cannot inherit from final ImageSource~~ Error: cannot inherit from final ImageSource after update react-native to 0.75.1 Aug 15, 2024

YuriOlepir changed the title ~~Error: cannot inherit from final ImageSource after update react-native to 0.75.1~~ [Error: cannot inherit from final ImageSource after update] react-native to 0.75.1 Aug 15, 2024

YuriOlepir changed the title ~~[Error: cannot inherit from final ImageSource after update] react-native to 0.75.1~~ [Error: cannot inherit from final ImageSource] after update react-native to 0.75.1 Aug 15, 2024

YuriOlepir mentioned this issue Aug 16, 2024

Cannot inherit from final ImageSource dream-sports-labs/react-native-fast-image#13

Closed

wangzhi17 mentioned this issue Aug 17, 2024

Cannot inherit from final 'com.facebook.react.views.imagehelper.ImageSource' facebook/react-native#46077

Closed

huextrat added a commit to appchoose/react-native-fast-image that referenced this issue Aug 19, 2024

fix RN 0.75.1 ImageSource

78b3773

DylanVann#1043 (comment)

huextrat added a commit to appchoose/react-native-fast-image that referenced this issue Aug 19, 2024

fix RN 0.75.1 ImageSource

a1c8789

DylanVann#1043 (comment)

huextrat added a commit to appchoose/react-native-fast-image that referenced this issue Aug 19, 2024

fix RN 0.75.1 ImageSource

f7a064b

DylanVann#1043 (comment)

deepanshushuklad11 mentioned this issue Sep 9, 2024

fix: image source final issue from react native dream-sports-labs/react-native-fast-image#44

Merged

[Error: cannot inherit from final ImageSource] after update react-native to 0.75.1 #1043

[Error: cannot inherit from final ImageSource] after update react-native to 0.75.1 #1043

Comments

YuriOlepir commented Aug 15, 2024

ahmaddehnavi commented Aug 15, 2024

Koykoy200078 commented Aug 16, 2024

divyangkhatri commented Aug 16, 2024

ramonxm commented Aug 16, 2024

aviral1518 commented Aug 16, 2024

Boscotec commented Aug 17, 2024 • edited Loading

deepanshushuklad11 commented Aug 17, 2024

hpanwar521 commented Aug 18, 2024 • edited Loading

aviral1518 commented Aug 18, 2024

hpanwar521 commented Aug 19, 2024

mohsenfl2022 commented Aug 19, 2024

aviral1518 commented Aug 19, 2024

NensiKasundra commented Aug 20, 2024 • edited Loading

deepanshushuklad11 commented Aug 20, 2024

NensiKasundra commented Aug 20, 2024

deepanshushuklad11 commented Aug 20, 2024

NensiKasundra commented Aug 20, 2024

ramonxm commented Aug 20, 2024

NensiKasundra commented Aug 21, 2024

NensiKasundra commented Aug 21, 2024

hamdij0maa commented Aug 22, 2024

gonzalorocha commented Aug 22, 2024

Kolahzary commented Aug 22, 2024

SpawN005 commented Aug 22, 2024

liptonzuma commented Aug 22, 2024

kodeandoec commented Aug 22, 2024

kodeandoec commented Aug 25, 2024

Hao-yiwen commented Aug 28, 2024

lukedanielson commented Aug 28, 2024

Thioby commented Sep 2, 2024

deepanshushuklad11 commented Sep 2, 2024

JohnSmall commented Sep 4, 2024

JohnSmall commented Sep 4, 2024

deepanshushuklad11 commented Sep 5, 2024

deepanshushuklad11 commented Sep 10, 2024

Gautham495 commented Sep 26, 2024

deepanshushuklad11 commented Sep 26, 2024

Gautham495 commented Sep 26, 2024

lucianolopezz commented Oct 22, 2024

Boscotec commented Aug 17, 2024 •

edited

Loading

hpanwar521 commented Aug 18, 2024 •

edited

Loading

NensiKasundra commented Aug 20, 2024 •

edited

Loading