Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup needed #10

Open
TheBlizWiz opened this issue Jun 28, 2020 · 1 comment
Open

Cleanup needed #10

TheBlizWiz opened this issue Jun 28, 2020 · 1 comment

Comments

@TheBlizWiz
Copy link

Now that the thing is confirmed to work, we ought to clean it up a bit. Ex: We have a gson that we imported but the only time it's ever used is in code that's commented out.

I also suggest we change all the public static final variables at the top to private variables and create some getters/setters for them since having them open like that causes security issues
@Dylancyclone
Copy link
Owner

I agree. Java is very much not my preferred language, and I spend almost all my time working with procedural languages so there's probably a lot of places where better Java/OOP principles can be used. I'll slowly start cleaning stuff up when I notice something is off.

Dylancyclone added a commit that referenced this issue Jul 5, 2020
@Dylancyclone
Lint fixes and code style improvements
ff0d356 
Mostly adding JavaDocs and spaces, but this also removes creating new gson objects in loops, which could boost performance somewhat

This begins to address issue #10, but mostly focus on stylistic things rather than java specific things like changing public variables to private. It's a process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dylancyclone @TheBlizWiz