-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Commons IP schema validation #60
Commits on Aug 11, 2024
-
FEAT: Commons IP schema validation
- removed expansions of status enums; and - added a `ruleId` alias for validation `rule_id`.
Configuration menu - View commit details
-
Copy full SHA for 491f9af - Browse repository at this point
Copy the full SHA 491f9afView commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e9dacbf - Browse repository at this point
Copy the full SHA e9dacbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f8ad91 - Browse repository at this point
Copy the full SHA 3f8ad91View commit details -
FIX: Deserialisation of rule_id
- added a `model_config` paramter to allow both `rule_id` and `ruleId` as keys in Pydantic model validation; - fixes issue with deserialisation of `rule_id` in `Rule` model.
Configuration menu - View commit details
-
Copy full SHA for 834fdfa - Browse repository at this point
Copy the full SHA 834fdfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d7d6a4 - Browse repository at this point
Copy the full SHA 9d7d6a4View commit details -
FEAT: Convert commons-ip representations
- added a `model_validator` to the `PackageDetails` class to convert incoming JSON dictionary to a `List` for now; - added PyDantic config to `Result` to allow multiple names for `rule_id` during validation; - reverted change to dictionary as it was not necessary; - added tests and data for deserialisation of commons-ip types; and - fixed minor compiler warnings.
Configuration menu - View commit details
-
Copy full SHA for 2935fdb - Browse repository at this point
Copy the full SHA 2935fdbView commit details -
Merge branch 'fix/commons-ip' of github.com:E-ARK-Software/eark-valid…
…ator into fix/commons-ip
Configuration menu - View commit details
-
Copy full SHA for ea44511 - Browse repository at this point
Copy the full SHA ea44511View commit details
Commits on Aug 28, 2024
-
FEAT: Final commons-ip compatibility tweaks
- refactored `MetadataResults` to match `commons-ip`, it's probably better as well; - moved `name` from `InformationPackage` to `PackageDetails` class; - renamed `InformationPackage.package` to `InformationPackage.details`; - renamed existing `ValidationReport.convert_dict` validator to `ValidationReport.convert_representations_dict` (more explicit); - added a second validator, `VaidationReport.convert_checksum_ids`, to convert `commons-ip` checksum ids to `eark_validator` hyphenated form; - `is_valid` convenience property to `ValidationReport` class; - string constants for 'VALID' and 'INVALID'; and - fixed tests to accomodate.
Configuration menu - View commit details
-
Copy full SHA for 56deacc - Browse repository at this point
Copy the full SHA 56deaccView commit details
Commits on Aug 29, 2024
-
FIX: Support commons-ip use of NOTVALID
- added `convert_status` validator to `MetadataResults` class to convert commons-ip `NOTVALID` status to `INVALID`; - moved checksum algorithm ID validation to the `PackageDetails` class; - added test and test data for status conversion; and - fixed type hinting for validation methods to `Any`.
Configuration menu - View commit details
-
Copy full SHA for 3d3ce76 - Browse repository at this point
Copy the full SHA 3d3ce76View commit details -
REV: Tidier use of ROOT in structure.py
As suggested in this [review comment](#60 (comment)), thanks.
Configuration menu - View commit details
-
Copy full SHA for 1c65fe9 - Browse repository at this point
Copy the full SHA 1c65fe9View commit details