Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange response for /getDetails Query #17

Open
pstoehr opened this issue Oct 26, 2015 · 9 comments
Open

Strange response for /getDetails Query #17

pstoehr opened this issue Oct 26, 2015 · 9 comments
Assignees

Comments

@pstoehr
Copy link

pstoehr commented Oct 26, 2015

The response for this

{
"loggingLevel": 0,
"queryID": "1174118456",
"documentBadge": [
{
"id": "24792b49-6db6-3af1-957d-3bcaf1003ff1",
"uri": "http://www.mendeley.com/research/saint-peter-1",
"provider": "Mendeley"
}
],
"origin": {
"clientType": "Swift-Test-Client",
"clientVersion": "0.21",
"module": "OS X Prototype",
"userID": "PDPS-WS2015"
}
}

/getDetails query

is this more or less empty json object:
{"documentBadge":[],"queryID":"1174118456"}

Why is the original information about id, uri, and provider removed? This happened never before and we thought that /getDetails function call adds something to the documentBadge-Information provided by the /recommend function call.

Endpoint for the /recommend and /getDetails-call:
https://eexcess-dev.joanneum.at/eexcess-privacy-proxy-issuer-1.0-SNAPSHOT/issuer/.

@chseifert
Copy link

Thomas, were there changes in the PP? (otherwise pls reassign to FR)

@ThomasCerq
Copy link

Nothing has changed recently on the PP, so I guess it comes from the FR. I think some changes have been made last week... I hand over to Hermann.

@ThomasCerq ThomasCerq assigned hziak and unassigned ThomasCerq Oct 27, 2015
@hziak
Copy link

hziak commented Oct 27, 2015

fixed it in a way that even on partner failure documentbadges should be returned

@hziak hziak assigned jr-dig-orgel and unassigned hziak Oct 27, 2015
@n-witt
Copy link

n-witt commented Oct 27, 2015

I'm currently facing a same problem and did some investigations. I found that there are three types of items:

  1. Items that I could never receive a result for
  2. Items that I could occasionally receive a result for (2-3 out of 10 tries)
  3. Items that I could almost always receive a result for.

Interestingly enough, I couldn't find a correlation regarding the data providers. Initially I assumed that there are some providers that respond faster than others and therefore their item are mostly type 3 items. But there are items of type 1 and 3 from the same provider in the same query.

What I also found is, that the problem can not be mitigated by reducing the number of item per query. Even queries with only one item show the same characteristics.

Type 1 example:

{
  "id":"24738970-9e37-3dc0-bb43-20d5c799b19b",
  "uri":"http://www.mendeley.com/research/diabetes-managed-care-lovelace-health-systems-episode-care-program",
  "provider":"Mendeley"
}

Type 2 example:

{
  "id":"/2022323/301B1706F223C8B81BDE555E89A8AFD42CE858B2",
  "uri":"http://europeana.eu/resolve/record/2022323/301B1706F223C8B81BDE555E89A8AFD42CE858B2",
   "provider":"Europeana"
}

Type 3 example:

{
  "id":"10004608579",
  "uri":"http://www.econbiz.de/Record/10004608579",
  "provider":"ZBW"
}

@pstoehr
Copy link
Author

pstoehr commented Oct 27, 2015

Is the version with the bugfix already online?

@hziak
Copy link

hziak commented Oct 27, 2015

not yet, will be deployed later on today

@hziak hziak closed this as completed Oct 27, 2015
@chseifert
Copy link

Reopen because

  • we don't know how this has been fixed (e.g., what if partner recommenders do not respond, will there be an error code or an empty badge)
  • this has not been tested since no deployment is available for the once reporting this issue

@chseifert chseifert reopened this Oct 27, 2015
@schloett
Copy link

The issue 22 in the recommender repo seems to be related, just mentioning it here to have a crossreference.

@pstoehr
Copy link
Author

pstoehr commented Oct 29, 2015

Works for us now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants