Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language information of a documentBadge doesn't match the description #18

Open
pstoehr opened this issue Oct 26, 2015 · 5 comments
Open
Assignees

Comments

@pstoehr
Copy link

pstoehr commented Oct 26, 2015

The documentation state that language information is returned as ISO 639-1 formatted string.

In some results returned from a /recommand api-call a lot of white-spaces, namely \t or \n, are added to the result.

Examples:
"documentBadge": {
"id": "224cf6a0-d075-45ed-980e-193654474cfc",
"uri": "http://culture.joanneum.at/catalog/online-katalog/?detail=224cf6a0-d075-45ed-980e-193654474cfc",
"provider": "\n\t\t\t\t\t\t\t\tKierling\n\t\t\t\t\t\t\t"
},
"mediaType": "text",
"title": "Probedruck, Priester mit Monstranz ",
"description": "\"Sel. Peter Julian\"",
"date": "unknown",
"language": "\n\t\t\t\t\t\tde\n\t\t\t\t\t",
"licence": "\n\t\t\t\t\t\thttp://creativecommons.org/licenses/by-nc-sa/4.0/\n\t\t\t\t\t",
"generatingQuery": "(Peter)"
},

"documentBadge": {
"id": "SK-A-133",
"uri": "https://www.rijksmuseum.nl/en/collection/SK-A-133",
"provider": "\n\t\t\t\t\t\t\t\tRijksMuseum\n\t\t\t\t\t\t\t"
},
"mediaType": "text",
"title": "Portrait of a Couple, Probably Isaac Abrahamsz Massa and Beatrix van der Laen",
"description": "Portrait of a Couple, Probably Isaac Abrahamsz Massa and Beatrix van der Laen, Frans Hals, c. 1622",
"date": "unknown",
"language": "\n\t\t\t\t\t\tde\n\t\t\t\t\t",
"licence": "\n\t\t\t\t\t\thttp://creativecommons.org/licenses/by-nc-sa/4.0/\n\t\t\t\t\t",
"generatingQuery": "(Peter)"
},

Is the client supposed to remove the whitespaces?

Endpoint for the queries:
https://eexcess-dev.joanneum.at/eexcess-privacy-proxy-issuer-1.0-SNAPSHOT/issuer

@chseifert
Copy link

Thomas, could you have a look on this. Seems to me part of the metadata mapping component.

@jr-dig-orgel
Copy link
Member

I have fixed this issue, and now the whitespaces should not appear anymore.

@pstoehr
Copy link
Author

pstoehr commented Oct 27, 2015

Would it be possible to remove the unneeded white spaces from all other strings too?

"result": [
{
"resultGroup": [

  ],
  "documentBadge": {
    "id": "B1.27872",
    "uri": "https:\/\/www.kgportal.bl.ch\/sammlungen#6e6ac78d-4098-9cc9-8cdb-1dbfb88c3344",
    "provider": "KIMPortal"
  },
  "mediaType": "text",
  "title": "Planta indeterminata",
  "date": "unknown",
  "language": "de",
  "licence": "http:\/\/creativecommons.org\/licenses\/by-nc-sa\/4.0\/\n\t\t\t\t\t\t\t",
  "generatingQuery": "Peter"
},

Compared to one of the buggy results from yesterday where all whitespaces are removed
{
"resultGroup": [

  ],
  "documentBadge": {
    "id": "224cf6a0-d075-45ed-980e-193654474cfc",
    "uri": "http:\/\/culture.joanneum.at\/catalog\/online-katalog\/?detail=224cf6a0-d075-45ed-980e-193654474cfc",
    "provider": "Kierling"
  },
  "mediaType": "text",
  "title": "Probedruck, Priester mit Monstranz ",
  "description": "\\\"Sel. Peter Julian\\\"",
  "date": "unknown",
  "language": "de",
  "licence": "http:\/\/creativecommons.org\/licenses\/by-nc-sa\/4.0\/",
  "generatingQuery": "(Peter)"
},

@chseifert chseifert reopened this Oct 27, 2015
@chseifert
Copy link

Reopened, because of similar behaviour in other fields.

@jr-dig-orgel
Copy link
Member

I have pushed a new version - in the next version hopefully all whitespaces show be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants