Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git submodules and externals #148

Open
jedwards4b opened this issue Sep 11, 2020 · 5 comments
Open

git submodules and externals #148

jedwards4b opened this issue Sep 11, 2020 · 5 comments

Comments

@jedwards4b
Copy link
Collaborator

Summary of Issue: currently a repo can have git submodules or externals but not both.

Expected behavior and actual behavior: Need to have both and need to have submodules update first

Steps to reproduce the problem (should include model description file(s) or link to publi c repository):

What is the changeset ID of the code, and the machine you are using:

have you modified the code? If so, it must be committed and available for testing:

Screen output or log file showing the error message and context:

@gold2718
Copy link
Collaborator

Is this true? While the ordering is an issue (possibly due to using hash ordering), what is preventing you from having an Externals.cfg file with a mix of submodule and externals info? If it does not work, please provide the "Steps to reproduce the problem".

@gold2718
Copy link
Collaborator

I have not been able to reproduce this but have come up with a counter-example so I am closing this.
Closing (see #149)

@jedwards4b
Copy link
Collaborator Author

First I think that it is at best inappropriate to close an issue without acknowledgement of the parties involved.
If you consider the line here you will see that git submodules are considered exclusive of externals.
https://github.com/ESMCI/manage_externals/blob/master/manic/sourcetree.py#L66

@jedwards4b jedwards4b reopened this Sep 15, 2020
@gold2718
Copy link
Collaborator

This issue is not appropriately opened in that it does have steps to reproduce and a couterexample was found.
Please add steps to reproduce or close this issue. Also, please note PR #150 which does fix an issue with submodules.

@gold2718
Copy link
Collaborator

If you consider the line here you will see that git submodules are considered exclusive of externals.
https://github.com/ESMCI/manage_externals/blob/master/manic/sourcetree.py#L66

That line is so that submodules are automatically considered an external. If you have an externals file, you can easily (and selectively) include submodules via the from_submodule idiom. See Externals_MOM.cfg in the Mom_interface repo as an example.

[pkg/MOM6_DA_hooks]
protocol = git
from_submodule=True
required = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants