Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] Icon Alignment Issue in SubNav Bar on Desktop View #9656

Closed
1 task done
mrical opened this issue Oct 29, 2023 · 8 comments · Fixed by #9681
Closed
1 task done

[BUG] Icon Alignment Issue in SubNav Bar on Desktop View #9656

mrical opened this issue Oct 29, 2023 · 8 comments · Fixed by #9681
Assignees
Labels
🛠 goal: fix undefined Hacktoberfest Good issues for Hacktoberfest participants 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@mrical
Copy link
Contributor

mrical commented Oct 29, 2023

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

production on biodrop.io

Version of BioDrop (for example "v1.2.3")

v2.83.8

Description

When a new user signs up or goes through the onboarding process, and when accessing the account panels, there is an issue with the alignment of icons in the SubNav bar on the desktop view. The icons in the SubNav bar are not center-aligned as they should be, leading to a visual inconsistency.

Screenshots

dFDbZpG1gh

Do you want to work on this issue?

Yes

If you want to work on this issue...

This can be solved by adding a tailwind CSS class responsible for center alignment on the button for SubNav,

Here's the result I have obtained on fixing this issue on my local environment

chrome_ZRUerPQO3i
@mrical mrical added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Oct 29, 2023
@github-actions
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2023
@SaraJaoude SaraJaoude added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 2 undefined Hacktoberfest Good issues for Hacktoberfest participants and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Oct 30, 2023
@github-actions github-actions bot unlocked this conversation Oct 30, 2023
@github-actions
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@SaraJaoude
Copy link
Member

Thank you for raising - the issue is very well written and this makes such a positive difference to the maintainers. I have assigned it to you.

@Luckydhingra
Copy link

Luckydhingra commented Oct 30, 2023

Thank you for raising - the issue is very well written and this makes such a positive difference to the maintainers. I have assigned it to you.

  • would like to work on this issue
  • Participating in Hacktoberfest 23

@sital002
Copy link
Member

@Luckydhingra Please look at the assignee section before asking for issue to be assigned. I would recommend you to read our contributing guidelines https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@mrical
Copy link
Contributor Author

mrical commented Oct 30, 2023

Hello! @SaraJaoude, Thanks for your kind words, I have created a PR #9681 which you can review and merge, you can ask me if there are any doubts regarding my pull request

ℹ️ mrical has some opened assigned issues: 🔧View assigned issues

@SaraJaoude
Copy link
Member

Thank you @mrical - may I ask that you do not tag a specific maintainer. All maintainers will receive the notification that the PR has been open, so this is just increasing the notifications.

@mrical
Copy link
Contributor Author

mrical commented Oct 30, 2023

@SaraJaoude, I am really sorry about that, It has been 2 years as a developer/freelancer but, this was my first contribution to open source I am not fully aware of every functionality, Thanks to you I gained some experience in open source 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 goal: fix undefined Hacktoberfest Good issues for Hacktoberfest participants 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants