Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating classes (room numbers) #130

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Updating classes (room numbers) #130

merged 4 commits into from
Sep 18, 2024

Conversation

riedde
Copy link
Contributor

@riedde riedde commented Sep 17, 2024

No description provided.

@riedde riedde self-assigned this Sep 17, 2024
peterstadler
peterstadler approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@peterstadler peterstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked numbers that there's no collision – looks good !

@riedde riedde requested a review from aseipelt September 18, 2024 10:43
aseipelt
aseipelt approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@aseipelt aseipelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@peterstadler peterstadler merged commit 416e442 into main Sep 18, 2024
1 check passed
@peterstadler peterstadler deleted the update/classes-and-rooms branch September 18, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aseipelt aseipelt aseipelt approved these changes

@peterstadler peterstadler peterstadler approved these changes

Assignees

@riedde riedde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riedde @peterstadler @aseipelt