MapPreview updates to support drawing & editing on map (JAM-5013) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 13, 2023 15:37
…g those down to the MapDraw component
…to show an empty map by default. Included new storybook story for this
…ons to be customized, and pass the leafletElement with the onCreated & onEdited callbacks instead of the FeatureGroup ref which is redundant/already available
… for more custom labels
parksjr
approved these changes
Oct 24, 2023
added 3 commits
October 31, 2023 13:13
… so we can allow edit specifically to be disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
MapPreviewfor supporting drawing on itMapPreviewDrawcomponent, basically same asMapDrawbut catered toMapPreviewinstead ofLensto avoid breaking changes to LensMapPreviewstorybook story to cover the empty MapPreview map + drawingMapDrawstorybook story as it displayed nothing & provides no valueInputButton&FormInputto allow JSX labels