-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gossip split #6355
Closed
+1,141
−55
Closed
gossip split #6355
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
45db07b
pytest: use wait_local_channel_active
endothermicdev 8baac40
gossipd: correctly attribute our own channel update to ourselves
endothermicdev 732c4d7
db: add private channel inbound fields
endothermicdev c55e46d
gossipd: pass remote private channel update to ld
endothermicdev 3abd0fe
lightningd: load and save remote private update data with channel
endothermicdev cd39e2a
lightningd: add listprivateinbound rpc
endothermicdev 1cf8d43
topology: listincoming: remove dependence on private gossip_store data
endothermicdev 0c92939
topology: begin deprecation of private channels in listchannels result
endothermicdev 44ef74f
cleanup comments
endothermicdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,8 @@ static struct gossmap *global_gossmap; | |
static struct node_id local_id; | ||
static struct plugin *plugin; | ||
|
||
extern bool deprecated_apis; | ||
|
||
/* We load this on demand, since we can start before gossipd. */ | ||
static struct gossmap *get_gossmap(void) | ||
{ | ||
|
@@ -440,6 +442,10 @@ static void json_add_halfchan(struct json_stream *response, | |
struct amount_sat capacity; | ||
bool local_disable; | ||
|
||
/* FIXME: deprecate private channels in listchannels result in 24.08 */ | ||
if (deprecated_apis) | ||
return; | ||
|
||
Comment on lines
+445
to
+448
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this backwards? I think a simple test is in order... |
||
/* These are channel (not per-direction) properties */ | ||
chanfeatures = gossmap_chan_get_features(tmpctx, gossmap, c); | ||
scid = gossmap_chan_scid(gossmap, c); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already declared in libplugin.h?