Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gossip split #6355

Closed
6 changes: 6 additions & 0 deletions plugins/topology.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ static struct gossmap *global_gossmap;
static struct node_id local_id;
static struct plugin *plugin;

extern bool deprecated_apis;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already declared in libplugin.h?


/* We load this on demand, since we can start before gossipd. */
static struct gossmap *get_gossmap(void)
{
Expand Down Expand Up @@ -440,6 +442,10 @@ static void json_add_halfchan(struct json_stream *response,
struct amount_sat capacity;
bool local_disable;

/* FIXME: deprecate private channels in listchannels result in 24.08 */
if (deprecated_apis)
return;

Comment on lines +445 to +448
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this backwards? I think a simple test is in order...

/* These are channel (not per-direction) properties */
chanfeatures = gossmap_chan_get_features(tmpctx, gossmap, c);
scid = gossmap_chan_scid(gossmap, c);
Expand Down
Loading