cln-grpc: do not generate cerficates when no autostart. #6755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
approved these changes
Oct 10, 2023
vincenzopalazzo
requested changes
Oct 12, 2023
…pc is not started. We update `test_grpc_no_auto_start` test to check that we do not generate certificates when the cln-grpc plugin is not started. This fails currently, so next commit fix it up.
Changelog-None
tonyaldon
force-pushed
the
cln-grpc-when-no-autostart-do-not-generate-certificates
branch
from
87fb39a to
00a60a3
Compare
|
Thanks @vincenzopalazzo for helping me with my first PRs in CLN and showing me exactly what to change. I also started to look at the CI logs to find the errors by myself (but maybe better not doing them in the first place). This is the second time this week I haven't checked Python flake8 before opening a PR. I'll try not to do that mistake in future. |
No problem the review are here for this :) I find always Python formatting is a little bit strange :) |
vincenzopalazzo
merged commit 7bea339
into
ElementsProject:master
33 of 38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we don't set
grpc-portoption, thecln-grpcplugin is not started. So, we shouldn't generate certificates in that case.