Add testnet4 entry in chainparams #7894
Open
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just as a driveby review comment: we don't use merge commits in CLN (your last commit is a merge commit). we use rebases. you'll need to remove that commit before this PR is eligible for being included in the main branch :) |
cdecker
force-pushed
the
add-testnet4-support
branch
from
8e98ad3 to
ebf3e84
Compare
|
Rebased on top of master in order to remove the merge commits. I also squashed the two fixups that you had. |
|
cACK |
|
Ah, I hate the |
… testnet4 to correspond with chaininfo value.
cdecker
force-pushed
the
add-testnet4-support
branch
from
28de1b3 to
1b58069
Compare
|
eek sorry. I should have checked first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an entry in chainparams for testnet4
Changelog-Added: entry in chainparams for testnet4
Important
24.11 FREEZE NOVEMBER 7TH: Non-bugfix PRs not ready by this date will wait for 25.02.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: