Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class="fancy" doesn't seem to do anything #1

Open
uglyeoin opened this issue Feb 9, 2017 · 2 comments
Open

class="fancy" doesn't seem to do anything #1

uglyeoin opened this issue Feb 9, 2017 · 2 comments

Comments

@uglyeoin
Copy link
Contributor

uglyeoin commented Feb 9, 2017

Hi there, I see lots of classes on your headings, fancy, thin, all sorts, but none seem to have related css classes. Am I being stupid?

Also all of the links look the same. I think they are supposed to look different aren't they?

Is this because you have inlined all of your styles?

Also you use RGB as a background colour, but 6 digit hex is recommended. https://litmus.com/community/learning/21-background-colors-in-html-email

I do a lot of work with emails and I think this is a cool project. If I knew what was supposed to happen I'll do some commits for you.

@bharani91
Copy link
Contributor

Hi, Sorry about that. I am still working on the styles for those classes. I've added it to the HTML as a reminder to myself that I need to implement those styles.

Thanks for the link about hex colors. Fixing it shortly.

@uglyeoin
Copy link
Contributor Author

uglyeoin commented Feb 9, 2017

No need to apologise I was initially confused. If I have any other input I'll send it over :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants