Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models with automatic epsilon injectors shouldn't list Epsilon as an input. #31

Open
tgolsson opened this issue Feb 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@tgolsson
Copy link
Member

tgolsson commented Feb 2, 2023

Per title - if one has a model like let inferer = EpsilonInjector<T>(...), then inferer.input_shapes() will still contain ("epsilon", [...]) - which isn't a logical input for an external user.

This can lead to bugs when validity checking external inputs.

Since this'd be a breaking change (semantically) fixing this should be bundled with deprecating the input/output shapes API in favor of the ModelAPI functionality (and adding some utilities to that, eg, rank, cardinality, accessors).

@tgolsson tgolsson added the bug Something isn't working label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant