You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per title - if one has a model like let inferer = EpsilonInjector<T>(...), then inferer.input_shapes() will still contain ("epsilon", [...]) - which isn't a logical input for an external user.
This can lead to bugs when validity checking external inputs.
Since this'd be a breaking change (semantically) fixing this should be bundled with deprecating the input/output shapes API in favor of the ModelAPI functionality (and adding some utilities to that, eg, rank, cardinality, accessors).
The text was updated successfully, but these errors were encountered:
Per title - if one has a model like
let inferer = EpsilonInjector<T>(...)
, theninferer.input_shapes()
will still contain("epsilon", [...])
- which isn't a logical input for an external user.This can lead to bugs when validity checking external inputs.
Since this'd be a breaking change (semantically) fixing this should be bundled with deprecating the input/output shapes API in favor of the ModelAPI functionality (and adding some utilities to that, eg, rank, cardinality, accessors).
The text was updated successfully, but these errors were encountered: