Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a wider range of input keying #32

Open
tgolsson opened this issue Feb 2, 2023 · 0 comments
Open

Allow a wider range of input keying #32

tgolsson opened this issue Feb 2, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@tgolsson
Copy link
Member

tgolsson commented Feb 2, 2023

The current input with zero-copy of the keys is very nice from a performance view, but it requires users to jump through hoops if it's not a 100% direct call (e.g. some of our internal incremental FFI patterns).

Having multiple ways of feeding data (borrowed key, owned key, indexed key?) would be neat in order to make this a bit more ergonomic.

Rabbit holes: How does this work if we also want to support other input types like i32 in the future? (Enum explosion?)

@tgolsson tgolsson added the enhancement New feature or request label Feb 2, 2023
@tgolsson tgolsson changed the title Make "Owned" string inputs more ergonomic Allow a wider range of input keying Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant