Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Fix psalm errors for level 8 #105

Open
dmohns opened this issue Jun 17, 2024 · 0 comments
Open

[Feature Request] Fix psalm errors for level 8 #105

dmohns opened this issue Jun 17, 2024 · 0 comments

Comments

@dmohns
Copy link
Member

dmohns commented Jun 17, 2024

Essentially a continuation of this PR: #106

Psalm detect's a couple of errors, mostly

Error: app/Services/RolesService.php:48:29: TooFewArguments: Too few arguments for method Illuminate\Database\Eloquent\Model::with saw 0 (see https://psalm.dev/025)
Error: app/modules/OutstandingDebts/OutstandingDebtsExportService.php:16:26: ParseError: Syntax error, unexpected T_STRING, expecting T_VARIABLE on line 16 (see https://psalm.dev/173)

Please fix these.

Update as of 2024-10-30. Currently psalm is no longer installed, see #325 An additional task here would bringing it back. However this only makes sense, after vimeo/psalm#11112 is resolved.

@dmohns dmohns changed the title Fix psalm errors for level 8 [Feature Request] Fix psalm errors for level 8 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant