Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Register page error message #378

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

beesaferoot
Copy link
Contributor

@beesaferoot beesaferoot commented Nov 23, 2024

Brief summary of the change made

The change adds a custom error message when the email address used already exists on the system.

Fixes #232

Preview:

Screenshot 2024-11-23 at 10 45 54 PM

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Quick suggestion regarding the error message wordings

src/frontend/src/assets/locales/en.json Outdated Show resolved Hide resolved
src/frontend/src/assets/locales/bu.json Outdated Show resolved Hide resolved
src/frontend/src/assets/locales/fr.json Outdated Show resolved Hide resolved
src/frontend/src/assets/locales/fr.json Outdated Show resolved Hide resolved
@beesaferoot
Copy link
Contributor Author

Updated, kindly reviewed @dmohns

Copy link
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍

Could you fix the linter? For the language JSON sorting you can find some information here: https://github.com/EnAccess/micropowermanager/blob/main/.github/workflows/check-ui.yml#L64

@beesaferoot beesaferoot force-pushed the register-error-message branch from f368562 to 4f7a924 Compare November 27, 2024 12:39
@beesaferoot
Copy link
Contributor Author

@dmohns Ready for review.

Copy link
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you :shipit:

@dmohns dmohns merged commit 2789232 into EnAccess:main Nov 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration Process Fails with Existing Credentials or Similar Email Addresses Without Specific Error Message
2 participants