Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demystify use of the term cluster in the context of Kubernetes #3168

Closed
shashimara opened this issue Sep 17, 2022 · 4 comments
Closed

Demystify use of the term cluster in the context of Kubernetes #3168

shashimara opened this issue Sep 17, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@shashimara
Copy link

shashimara commented Sep 17, 2022

it is troubling the use of the generic name "cluster" for PG custom resources. Many not familiar with the postgres assume "cluster" is referring to the Kubernetes cluster.

It will be good for commands in the doc if you could use PG-Cluster-name so the customers are aware of what is that support is looking adn will not error out while sending the document for troubleshooting

For Example / suggestion
kubectl cnp restart [PGclusterName]

kubectl cnp report cluster <PGclusterName> [flags]

Thanks

@drothery-edb drothery-edb self-assigned this Sep 27, 2022
@josh-heyer
Copy link
Contributor

Not sure I'm a fan of that particular placeholder name, but agree there can be ambiguity right now - we'll try to make time for a review of the use of "cluster" in these docs in the future!

@drothery-edb drothery-edb added the good first issue Good for newcomers label Feb 6, 2023
@drothery-edb drothery-edb removed their assignment Mar 30, 2023
@drothery-edb drothery-edb changed the title Feedback on /postgres_for_kubernetes/1/cnp-plugin.mdx Demystify use of the term cluster in the context of Kubernetes Apr 27, 2023
@djw-m
Copy link
Contributor

djw-m commented Jun 5, 2023

Not sure I'm a fan of that particular placeholder name, but agree there can be ambiguity right now - we'll try to make time for a review of the use of "cluster" in these docs in the future!

Added to that is the use of the word cluster is embedded in various commands and baked into the CNPG docs. In both those examples above, they are referring to a Kubernetes cluster which is configured with Postgres instances.

Taking this over to the Terminology discussion elsewhere, but am concerned that there is no obvious way to discriminate between two completely different cultural uses of cluster without always prefixing - postgres-cluster kubernetes-cluster - in all references.

@djw-m
Copy link
Contributor

djw-m commented Jul 5, 2023

This is more for the meta issue of text references to clusters: https://docs.google.com/document/d/1hNyLSVi6DTw2Bd3069fz9ctiNAi_HTi2jTgnRKBLdsQ/edit?usp=sharing

Basically:

There are a lot of clusters in the EDB world.

Trying to not use the word cluster is not going to work. There are few alternatives and most clash with common usage.

Therefore, this proposal is to make it an essential style rule that all clusters are preceded by a clarifying type.

Postgres cluster - A Postgres server which hosts a number of databases (trad Postgres community usage)

PGD cluster - A Postgres Distributed system comprised of a top-level group of nodes and subgroups.

K8S/Kuberbetes cluster - A Kubernetes cluster, multiple nodes which run containerized applications (trad K8S community usage)


With reference to the original issue this would translate to a placeholder name of PostgresClusterName

@josh-heyer
Copy link
Contributor

Closing in favor of #4879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants