Improve prior build error message #889
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is an error during the attempt of building a builtin prior (methods implemented in SpaceBuilder), the builder assumes the expression is not a builtin prior and then tries to create a scipy.stat prior which also fails. The error message is then that the name of the expression is not a valid prior. We should instead explicitly verify if the name of the prior is one that is builtin and then try to build it without silencing error messages. This way we get the correct error message for the prior.
bouthilx
added
the
enhancement
lebrice
approved these changes
May 17, 2022
lebrice
reviewed
May 17, 2022
| self, dimbuilder | ||
| ): | ||
| """Build fails because ValueError happens on init of builtin prior.""" | ||
| with pytest.raises(ValueError) as exc: |
There was a problem hiding this comment.
You could use the match argument of raises instead of checking if the value is in the exception message, I think.
(That might be only true for pytest.warns though, not 100% sure).
There was a problem hiding this comment.
Indeed. This test is looking at two different parts of exc.value however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an error during the attempt of building a builtin prior
(methods implemented in SpaceBuilder), the builder assumes the
expression is not a builtin prior and then tries to create a scipy.stat
prior which also fails. The error message is then that the name of the
expression is not a valid prior. We should instead explicitly verify if
the name of the prior is one that is builtin and then try to build it
without silencing error messages. This way we get the correct error
message for the prior.