Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update warnIfMissingRequiredProp util to handle properties which are not required #11007

Open
1 of 13 tasks
anveshmekala opened this issue Dec 7, 2024 · 0 comments
Open
1 of 13 tasks

refactor: update warnIfMissingRequiredProp util to handle properties which are not required #11007

anveshmekala opened this issue Dec 7, 2024 · 0 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@anveshmekala
Copy link
Contributor

anveshmekala commented Dec 7, 2024 •
edited
Loading

Description

Currently, we are utilizing logger util & console.warn for warn messages . This issue is to update warnIfMissingRequiredProp util to handle such use case where properties are not marked as required but affects functionality of the component.

Ex: PR 10887

Proposed Advantages

  • Easy to maintain and read
  • cleaner code

Which Component

  • block
  • color-picker
  • input
  • input-date-picker
  • input-number
  • list
  • popover
  • tooltip

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components
@anveshmekala anveshmekala added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. estimate - 2 Small fix or update, may require updates to tests. labels Dec 7, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Dec 7, 2024
@anveshmekala anveshmekala mentioned this issue Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anveshmekala