Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Item - some elements are misaligned #11031

Open
2 of 6 tasks
ashetland opened this issue Dec 11, 2024 · 4 comments
Open
2 of 6 tasks

List Item - some elements are misaligned #11031

ashetland opened this issue Dec 11, 2024 · 4 comments
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@ashetland
Copy link

ashetland commented Dec 11, 2024

Check existing issues

Actual Behavior

In the new v3 List, the drag handle, selection icon, expand chevron, and action-start slot are misaligned when compared to the main item content.

Expected Behavior

Elements to the left of and inside the bordered area should align to each other. Possible solution is to update the bordered-area to use box-sizing: border-box;

Reproduction Sample

https://codepen.io/ashetland/pen/GgKjjQb

Reproduction Steps

Compare the position of icons in the aforementioned elements vs those in the content area.

Reproduction Version

v3.0.0-next.57

Relevant Info

cc @eriklharper

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 11, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Dec 11, 2024
@ashetland
Copy link
Author

cc @ellenupp

@ashetland
Copy link
Author

@geospatialem This is a follow-up to #7100.

@geospatialem geospatialem added estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Dec 13, 2024
@driskull
Copy link
Member

To accommodate the new border design, everything to the left of the bordered content area needs 1px of bottom space added to align correctly.

Can the area with the border use border-box box sizing to address this?

@ashetland
Copy link
Author

Thanks @driskull! Updated the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

3 participants