Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing prop values for token tests #11037

Open
DitwanP opened this issue Dec 12, 2024 · 0 comments
Open

Add missing prop values for token tests #11037

DitwanP opened this issue Dec 12, 2024 · 0 comments
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.

Comments

@DitwanP
Copy link
Contributor

DitwanP commented Dec 12, 2024

Priority impact

p - low

Summary

Certain props do not currently have correct values assigned to them so when trying to test tokens that affects said props, the tests will always fail.

For example: fontWeight and marginBlockStart

image

Desired Outcome

Have correct values for props so that tokens that effects them can be tested.

Resources

No response
@DitwanP DitwanP added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 12, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Dec 12, 2024
@DitwanP DitwanP changed the title Add prop values for more props in token tests Add missing prop values for token tests Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DitwanP