Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the set_resolutions option to resolve mandatory receptor issues #1267

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Removing the set_resolutions option to resolve mandatory receptor issues #1267

merged 2 commits into from
Jun 17, 2024

Conversation

itopcuoglu
Copy link
Contributor

No description provided.

@itopcuoglu
Removed the input file option set_resolutions to avoid mandatory rece…
f27ed29 
…ptor issues related to Tioga's dependency on the shape of partition boundaries. Cell and node resolutions are calculated in Nalu-Wind prior to being passed to Tioga, which consistently marks outer boundary adjacent shared nodes as mandatory fringes across all ranks.
@psakievich
Copy link
Contributor

Are you sure this is never needed?

@itopcuoglu
Copy link
Contributor Author

None of the past regression tests use the set_resolutions: no option. We could also leave it in place, and make the code display a warning to say something like "WARNING: Nodal resolutions calculated by Tioga are not communicated at shared nodes. Use the default option "set_resolutions: yes" to ensure consistency at shared nodes".

@psakievich
Copy link
Contributor

Seems reasonable to me then.

@psakievich psakievich merged commit 2dfa52e into Exawind:master Jun 17, 2024
1 of 3 checks passed
@mbkuhn mbkuhn mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psakievich psakievich psakievich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itopcuoglu @psakievich