Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Quest Complete toast triggered multiple times for quests with optional tasks. #1390

Open
Mornedil opened this issue Nov 14, 2024 · 0 comments
Labels
1: Bug Problem with the usage of a mod. FTB Quests state: Fixed in Dev 🛠️ An issue is fixed in-dev and pending for release.

Comments

@Mornedil
Copy link

Mod

FTB Quests

Mod version

ftb-quests-fabric-2001.4.9

NeoForge / Forge / Fabric version

0.16.9

Modpack & version

No response

What issue are you having?

Optional tasks will trigger the "Quest complete" toast even if the quest is already marked as complete.

For example:
Quest: Observe wildlife!
Task 1: Observe a bee (optional)
Task 2: Observe a zombie (optional)

You now go observe a bee, which will show a "Task Complete" + "Quest Complete" toast.

Expected behavior after this point is to not show any more toasts for this quest, since it has been completed and the reward is accessible.

However, if you then go observe a zombie, it will once again show a "Task Complete" + "Quest Complete" toast.

To prevent this, there should either be a task/quest setting to disable toasts after a quest has been completed, or a setting to auto-complete or gray out optional tasks after the quest is marked as complete.

Crashlogs

No response

Steps to reproduce

  1. Make a new quest.

  2. Add 2 optional tasks - Task A and Task B.

  3. Complete optional Task A

  4. Complete optional Task B

  5. Observe as the toast for completing the quest is shown twice.

Anything else to note?

No response

@Mornedil Mornedil added the 1: Bug Problem with the usage of a mod. label Nov 14, 2024
desht added a commit to FTBTeam/FTB-Quests that referenced this issue Nov 19, 2024
Can happen if a quest has multiple optional tasks where completing one
task completes the quest.

FTBTeam/FTB-Mods-Issues#1390
@desht desht added the state: Fixed in Dev 🛠️ An issue is fixed in-dev and pending for release. label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Bug Problem with the usage of a mod. FTB Quests state: Fixed in Dev 🛠️ An issue is fixed in-dev and pending for release.
Projects
None yet
Development

No branches or pull requests

2 participants