Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@JsonIncludeProperties & @JsonIgnoreProperties is ignored when deserializing Records #4629

Open
1 task done
yihtserns opened this issue Jul 21, 2024 · 2 comments
Open
1 task done
Labels
2.18 has-failing-test Indicates that there exists a test case (under `failing/`) to reproduce the issue Record Issue related to JDK17 java.lang.Record support

Comments

@yihtserns
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Describe the bug

A JSON field:

  • Not included in @JsonIncludeProperties, or
  • Included in @JsonIgnoreProperties

...will still get deserialized as a Record's component with the same name.

Version Information

Oldest I tried this with is 2.14.2, latest is 2.18.

Reproduction

For @JsonIncludeProperties

record Id2Name(int id, String name) {
}
record RecordWithJsonIncludeProperties(@JsonIncludeProperties("id") Id2Name child) {
}

RecordWithJsonIncludeProperties value = new ObjectMapper().readValue("{\"child\":{\"id\":123,\"name\":\"Bob\"}}", RecordWithJsonIncludeProperties.class);
// failed with:
// org.opentest4j.AssertionFailedError:
// Expected :RecordWithJsonIncludeProperties[child=Id2Name[id=123, name=null]]
// Actual   :RecordWithJsonIncludeProperties[child=Id2Name[id=123, name=Bob]]
assertEquals(new RecordWithJsonIncludeProperties(new Id2Name(123, null)), value);

For @JsonIgnoreProperties

record Id2Name(int id, String name) {
}
record RecordWithJsonIgnoreProperties(@JsonIgnoreProperties("name") Id2Name child) {
}

RecordWithJsonIgnoreProperties value = new ObjectMapper().readValue("{\"child\":{\"id\":123,\"name\":\"Bob\"}}", RecordWithJsonIgnoreProperties.class);
// failed with:
// org.opentest4j.AssertionFailedError:
// Expected :RecordWithJsonIgnoreProperties[child=Id2Name[id=123, name=null]]
// Actual   :RecordWithJsonIgnoreProperties[child=Id2Name[id=123, name=Bob]]
assertEquals(new RecordWithJsonIgnoreProperties(new Id2Name(123, null)), value);

Expected behavior

No response

Additional context

NOTE: I'm not personally affected by this, just something I found when testing for #4626 - I thought they have the same cause, but apparently not.

@yihtserns yihtserns added the to-evaluate Issue that has been received but not yet evaluated label Jul 21, 2024
@cowtowncoder cowtowncoder added Record Issue related to JDK17 java.lang.Record support 2.18 and removed to-evaluate Issue that has been received but not yet evaluated labels Jul 21, 2024
@cowtowncoder
Copy link
Member

@yihtserns Assuming these still fail for 2.18.2, would it be possible to create pr for failing test to be added under src/test/java/.../tofix?

JooHyukKim added a commit to JooHyukKim/jackson-databind that referenced this issue Dec 1, 2024
@cowtowncoder cowtowncoder added the has-failing-test Indicates that there exists a test case (under `failing/`) to reproduce the issue label Dec 1, 2024
@cowtowncoder
Copy link
Member

Failing/tofix test added via #4823 to help verification if and when someone works on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.18 has-failing-test Indicates that there exists a test case (under `failing/`) to reproduce the issue Record Issue related to JDK17 java.lang.Record support
Projects
None yet
Development

No branches or pull requests

2 participants