Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javax.money support (from zalando / jackson-datatype-money) #5

Open
cowtowncoder opened this issue Oct 2, 2020 · 9 comments
Open
Labels
pr-welcome Issue for which progress most likely if someone submits a Pull Request

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Oct 2, 2020

(from: zalando/jackson-datatype-money#224)

Author existing jackson-datatype-money seems supportive of the idea, to help release new versions, so it would be nice to integrate this, ideally in time for Jackson 2.12.0 (but if not immediate, soon after is fine too).

@cowtowncoder cowtowncoder changed the title Add zalando / jackson-datatype-money? Add javax.money support (from zalando / jackson-datatype-money) Oct 2, 2020
@mathieu
Copy link

mathieu commented Oct 3, 2020

Hi @cowtowncoder,

From the original discussion from zalando/jackson-datatype-money#224 it seems that it’s author was willing to do just this.

Do you really need somebody else on this integration ?

@cowtowncoder
Copy link
Member Author

@mathieu Hi there! I was thinking that since actual migration itself could be relatively straight-forward task for someone with Maven knowledge, it'd be good task for Hacktoberfest participants. My intent was not bypass anyone, so I added a note on the other issue: if author or anyone else is working on this I do not want duplicate work.

Thank you for pointing this out; I realized that although github links issues via reference, it makes sense to add some not to explain addition here.

@mathieu
Copy link

mathieu commented Oct 6, 2020

Hi @cowtowncoder, it looks like I could help. Could you please explain the recommended course of actions ?

@cowtowncoder
Copy link
Member Author

I assume you are familiar with creating Pull Requests part (fork this repository, make changes, create PR)?

So the idea would be to add a Maven sub-project, similar to 3 existing ones (see parent pom.xml, individual subfolder/pom.xmls).
pom.xml of the new sub-project needs to change; version referenced.
Should be able to copy code under src/main/java and src/test/java as is.

@mathieu
Copy link

mathieu commented Oct 6, 2020

So basically copy and paste it as is into this repo ? (with minor version and parent pom changes)

@cowtowncoder
Copy link
Member Author

@mathieu correct: first step is just to make it build the same way as before, no functional changes.

Oh, and should be done for 2.12 branch.

@pgehl
Copy link

pgehl commented Jun 6, 2024

any news on this issue ?

@cowtowncoder cowtowncoder added the pr-welcome Issue for which progress most likely if someone submits a Pull Request label Jun 6, 2024
@cowtowncoder
Copy link
Member Author

@pgehl No updates here, no news. At this point blocked by zalando/jackson-datatype-money#224 I think, so asking over there would make sense.

If anyone wants to try it -- doing PR for addition is not blocked; but we would not want to merge before Zalando folks would be ok with the move -- this would be against 2.18 branch.
As usual, I may not have time to drive this, but am happy to help guide others as needed.

@cowtowncoder
Copy link
Member Author

There is now some progress, see #48!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-welcome Issue for which progress most likely if someone submits a Pull Request
Projects
None yet
Development

No branches or pull requests

3 participants