[BUGFIX] Use page layout specific column labels #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ This patch breaks backend layout selection in the page settings on TYPO3 v10 without fluidpages, while it worked fine on v8 with fluidpages. When using this flux patch together with the test_provider_extension, selecting the page layout "Other Template" or "Page template in sub-folder" leads to an error:
Adding the "extensionName" property to the page layout's |
cweiske
force-pushed
the
page-layout-column-labels
branch
from
5a6c782 to
cc57934
Compare
|
The TYPO3 v10 problem is fixed now. |
Labels of columns in page layouts were only translatable with the generic non-specific key "flux.grid.columns.$columnName". This patch sets the page layout's grid parent object to be the page layout's form, so that the resolved parent ID is that of the form. A column named "one" within a page layout with id "twocol" will thus get the label key "flux.twocol.columns.one", just as it was for flux 8. If the backend layout cannot be found because the page template file does not exist anymore, we need to return NULL from buildBackendLayout() to get a proper error message. Resolves: FluidTYPO3#1468
cweiske
force-pushed
the
page-layout-column-labels
branch
from
cc57934 to
461b9f2
Compare
|
Works fine on TYPO 9 and 10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels of columns in page layouts were only translatable with the generic
non-specific key "flux.grid.columns.$columnName".
This patch sets the page layout's grid parent object to be the page layout's form,
so that the resolved parent ID is that of the form.
A column named "one" within a page layout with id "twocol" will thus get
the label key "flux.twocol.columns.one", just as it was for flux 8.
Resolves: #1468