Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Undo for "Remove from Playlist" #5421

Open
3 tasks done
aleksejrs opened this issue Jul 15, 2024 · 9 comments · May be fixed by #5885
Open
3 tasks done

[Feature Request]: Undo for "Remove from Playlist" #5421

aleksejrs opened this issue Jul 15, 2024 · 9 comments · May be fixed by #5885
Assignees
@Soham456
Labels
E: improvement existing feature E: new feature enhancement New feature or request good first issue Good for newcomers

Comments

@aleksejrs
Copy link

aleksejrs commented Jul 15, 2024 •
edited
Loading

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Screenshot of the buttons: Add to playlist, Add to the favorite playlist, Move Video Up, Remove from Playlist
v0.21.1 Beta

The "Remove from Playlist" button on a video thumbnail is right next to the "Move Video Up"/"Move Video Down" button, making it easy to remove a video by accident. But there seems to be no way to undo that.

Proposed Solution

Make an undo button appear somewhere, preferably with multiple steps and not too ephemeral.

Alternatives Considered

Make Ctrl+Z undo the removal. Currently it affects the search field.

Issue Labels

improvement to existing feature, new feature

Additional Information

v0.21.1 Beta
@aleksejrs aleksejrs added the enhancement New feature or request label Jul 15, 2024
@kommunarr
Copy link
Collaborator

Toast on removal with a click to undo sounds like a fine idea. A keyboard shortcut to trigger the toast click action sounds like an interesting idea, but out of scope.

@kommunarr kommunarr added the good first issue Good for newcomers label Jul 19, 2024
@amit918
Copy link

amit918 commented Jul 26, 2024

Is this issue resolved ?

@aleksejrs
Copy link
Author

No, it's open.

@nirmalkumarnikam
Copy link

I am not able to understand what is the problem... It looks fine to me.
image
image
@aleksejrs can you share more detail on the issue.

@aleksejrs
Copy link
Author

aleksejrs commented Aug 21, 2024 •
edited
Loading

@nirmalkumarnikam Not the default playlist, but the playlist you are currently looking at. You have to go to a playlist from FreeTube's Playlists page.

@nirmalkumarnikam
Copy link

image

I think they have removed the move button. I will start working on how to do the undo part. I may make a pop-up that has an undo option.

@AviralDewan
Copy link

Is the issue still open?
If yes, then can you please assign it to me?

@Soham456
Copy link

Soham456 commented Oct 9, 2024

hey is this issue still open please assign it to me.
I have solved this issue and can create a pr

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Done.

Soham456 added a commit to Soham456/FreeTube that referenced this issue Oct 9, 2024
@Soham456
created undo feature for remove from playlist FreeTubeApp#5421
3243dea
Soham456 added a commit to Soham456/FreeTube that referenced this issue Oct 9, 2024
@Soham456
created undo feature to remove from playlist. issue FreeTubeApp#5421
dd1ce22
@Soham456 Soham456 mentioned this issue Oct 9, 2024
Closed
@Soham456 Soham456 linked a pull request Oct 17, 2024 that will close this issue
Open
1 task
@LinuxOnTheDesktop LinuxOnTheDesktop mentioned this issue Nov 2, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soham456 Soham456

Labels
E: improvement existing feature E: new feature enhancement New feature or request good first issue Good for newcomers
Projects
Feature Requests
Status: To assign
Milestone
No milestone
7 participants
@aleksejrs @Soham456 @AviralDewan @efb4f5ff-1298-471a-8973-3d47447115dc @kommunarr @nirmalkumarnikam @amit918