Filter out unsupported watch page only mixes from search results #6244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
|
What is mixes... (I never use Youtube unless leaving comments which is rare) |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 2, 2024
ChunkyProgrammer
approved these changes
Dec 5, 2024
kommunarr
approved these changes
Dec 5, 2024
github-actions
bot
removed
the
PR: waiting for review
jlvivero
pushed a commit
to jlvivero/FreeTube
that referenced
this pull request
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out unsupported watch page only mixes from search results
Pull Request Type
Related issue
Description
Watch page only mixes are not supported in FreeTube as they only exist on the YouTube watch page, that means they don't have their own playlist pages. Those unsupported mix playlists used to be filtered out automatically as they had their own
Mixnode which we didn't parse, but now YouTube has switched them to the sameLockupViewwithcontent_type = 'PLAYLIST'that they use for normal playlists.Some mixes such as the ones on
https://youtube.com/musichave actual playlist pages, they can be identified by the fact that their playlist IDs start withRDCL, which this pull request explicitly checks for to make sure that those types don't get filtered out.Testing
Search for
musicand check that the mix playlist doesn't show up in the local API search results.Desktop