Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of transportState filter #84

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

flkasper
Copy link
Contributor

Resolves #83

@flkasper flkasper force-pushed the feature/transportState-filter branch from c903684 to 2492917 Compare August 20, 2024 21:45
@tinect
Copy link
Member

tinect commented Aug 24, 2024

Hey @flkasper
thank you for the PR. When using the new filter, I miss the relevant info in the grid. What do you think of adding the transportState also in column - not just showing the red icon on createAt column?

@flkasper
Copy link
Contributor Author

@tinect Column added.
I have also moved the failed icon to the new column, as they belong together.

@tinect
Copy link
Member

tinect commented Aug 26, 2024

Great, thank you! I've added a few adjustments. Would you please check the PR on your fork? flkasper#1

feat: simplified translation of states and updates english translations
@flkasper
Copy link
Contributor Author

@tinect I had also considered including your adjustments, but then left them out because they are only indirectly related to the new feature and would usually be done in a second PR.

@shyim
Copy link
Member

shyim commented Aug 27, 2024

@tinect
image

you can push into prs FYI 😂

@tinect
Copy link
Member

tinect commented Aug 27, 2024

@tinect image

you can push into prs FYI 😂

@shyim For unknown reasons I had no permissions to do so :-(

@tinect tinect merged commit c1770b8 into FriendsOfShopware:2.x Aug 27, 2024
10 checks passed
@tinect
Copy link
Member

tinect commented Aug 27, 2024

@flkasper thank you. I will do a few testings, create an release vor v2 and migrate it to v3.

thank you very much!

tinect added a commit that referenced this pull request Aug 27, 2024
* feat: Implementation of transportState filter

* feat: simplified translation of states and updates english translations

---------

Co-authored-by: tinect <[email protected]>
@flkasper flkasper deleted the feature/transportState-filter branch August 31, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants