Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Results Text is moveable #3845

Open
2 tasks done
JVNpixels opened this issue Nov 10, 2024 · 6 comments
Open
2 tasks done

Bug Report: Results Text is moveable #3845

JVNpixels opened this issue Nov 10, 2024 · 6 comments
Assignees
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.

Comments

@JVNpixels
Copy link
Contributor

Issue Checklist

  • I have properly named my issue
  • I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

v0.5.3

Description (include any images, videos, errors, or crash logs)

I was spamming arrow keys in the results screen for fun, but then I saw that the text was moving?
(Hitsounds were included for proof of pressing arrow keys)

Friday.Night.Funkin.2024-11-09.21-38-51.mp4

Nothing really else to say, but I don't know if this was an intentional debug feature that was left in by mistake or something?

Steps to Reproduce

  1. Open the game...
  2. Beat a week/song through Story Mode or Freeplay
  3. Get to the results screen
  4. Press arrow keys and (maybe) see error.
@JVNpixels JVNpixels added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. labels Nov 10, 2024
@JVNpixels
Copy link
Contributor Author

I am still able to reproduce without mods.

@AbnormalPoof
Copy link
Contributor

Looks like this is some leftover debug code!
https://github.com/FunkinCrew/Funkin/blob/9e13ea0b2c0799d9a7fae7db56eddb05898739d0/source/funkin/play/ResultState.hx#L724C1-L729C6

@amyspark-ng
Copy link
Contributor

i've known about this for months but didn't want people to find out so they don't remove it 😔

@AbnormalPoof
Copy link
Contributor

i've known about this for months but didn't want people to find out so they don't remove it 😔

import funkin.play.ResultState;
import funkin.modding.module.Module;
import flixel.FlxG;

class ResultsThing extends Module {
	public function new() {
		super('ResultsThing');
	}

	function onUpdate() {
	    if (FlxG.state.subState is ResultState) {
	      if (FlxG.keys.justPressed.RIGHT) FlxG.state.subState.speedOfTween.x += 0.1;
	      if (FlxG.keys.justPressed.LEFT) FlxG.state.subState.speedOfTween.x -= 0.1;
	    }
	}
}

Copy link
Member

thank you very much! when this issue gets closed, it means its fixed internally, thanks!

@ninjamuffin99 ninjamuffin99 self-assigned this Dec 2, 2024
@JVNpixels
Copy link
Contributor Author

no problem ninjamuffin, i love you bro. (kisses cutely)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

4 participants