Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Mouse cursor is no longer visible outside of the ingame editors #3881

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sphis-Sinco
Copy link

@sphis-Sinco sphis-Sinco commented Nov 19, 2024

Does this PR close any issues? If so, link them below.

#3879
#3712

Briefly describe the issue(s) fixed.

  • The mouse cursor is no longer visible outside of ingame editors

Include any relevant screenshots or videos.

Before:

screenshot-2024-11-19-13-54-38

After:

8mb.video-q2j-xzbmpXIa.mp4

@github-actions github-actions bot added small A small pull request with 10 or fewer changes haxe Issue/PR modifies game code and removed small A small pull request with 10 or fewer changes labels Nov 19, 2024
@sphis-Sinco sphis-Sinco changed the title Mouse cursor is no longer visible outside of the ingame editors [BUGFIX] Mouse cursor is no longer visible outside of the ingame editors Nov 19, 2024
Copy link
Contributor

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the cursor just be re-enabled when you enter and exit an in-game editor? This doesn't really do anything.

I think a proper solution would be to hide the cursor when you exit an editor.

EDIT: I just realized that the Chart Editor and Stage Editor already do this! This PR seems good otherwise.

@sphis-Sinco
Copy link
Author

Wouldn't the cursor just be re-enabled when you enter and exit an in-game editor? This doesn't really do anything.

I think a proper solution would be to hide the cursor when you exit an editor.

EDIT: I just realized that the Chart Editor and Stage Editor already do this! This PR seems good otherwise.

:>

Copy link
Contributor

@anysad anysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro FINALLY, I was too lazy to do this PR myself, I'm glad someone decided to address this issue, the cursor was driving me a bit insane.

@sphis-Sinco
Copy link
Author

bro FINALLY, I was too lazy to do this PR myself, I'm glad someone decided to address this issue, the cursor was driving me a bit insane.

i just have a thing for small details no one will gaf about

@EliteMasterEric
Copy link
Member

Does this actually fix the issue in the circumstances where it happens?

I believe the issue was related to the Flixel debugger (and the linked issue also references the screenshot feature).

@sphis-Sinco
Copy link
Author

Does this actually fix the issue in the circumstances where it happens?

I believe the issue was related to the Flixel debugger (and the linked issue also references the screenshot feature).

I fixed it by hiding the cursor in InitState

@sphis-Sinco
Copy link
Author

Does this actually fix the issue in the circumstances where it happens?

I believe the issue was related to the Flixel debugger (and the linked issue also references the screenshot feature).

I was using the screenshot feature

@sphis-Sinco sphis-Sinco reopened this Nov 27, 2024
@sphis-Sinco
Copy link
Author

that was accidental

@github-actions github-actions bot added the small A small pull request with 10 or fewer changes label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
haxe Issue/PR modifies game code small A small pull request with 10 or fewer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants