-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Put Console Traces in Crash Logs (with Blacklisted Classes) #3897
base: develop
Are you sure you want to change the base?
Conversation
I feel like that would make it a bit more difficult to debug issues if you put EVERY one of the traces in there. But maybe like a select few? |
I would suggest making more like a separate log folder, kinda like Minecraft, so you don't need to crash the game to see logs |
I don't really see the need to do that, it would fill up the storage quickly - the traces in logs are just for better determining what caused the crash since most of the code does a trace. |
I feel like putting every single trace in the log file will make it a lot harder to read through crash reports in Issues. |
I should probably have updated the title of this PR when I added a featureflag to blacklist some classes from having their traces appear in the logs (such as DiscordClient (trace every update) or FunkinPreloader (trace for everything loaded)) |
Description
This Pull Request adds everything printed on the console via
trace
to crash logs in order to better determine the culprit of the crash. It also contains a feature flagBLACKLIST_TRACE_CLASSES
which, when enabled, blacklists some classes defined inAnsiTrace
from having their traces appear in the logs (such as the preloader class or the discord client class)Include any relevant screenshots or videos.
2024-11-26.21-36-21.mp4