[CODE REWORK] Replace ControlsMenu's Header Hard-code with a Soft-code #3907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Technically it helps answer the discussion 3906 because custom headers aren't otherwise possible (even though custom controls aren't possible either)
Briefly describe the issue(s) fixed.
Replaces the somewhat big hardcode in
ControlsMenu
with softcode. For comparison, this is how the game handles the name of the headers currently:(insert that one yanderedev tweet)
Tiny Issue
The header for Note controls is now named "Note" instead of "Notes" - to fix it I would have to change the names of the values for the enum Control, which would break a lot of things, or to add a hardcode for this scenario which I was trying to avoid this entire time