Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODE REWORK] Replace ControlsMenu's Header Hard-code with a Soft-code #3907

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

KoloInDaCrib
Copy link
Contributor

Does this PR close any issues? If so, link them below.

Technically it helps answer the discussion 3906 because custom headers aren't otherwise possible (even though custom controls aren't possible either)

Briefly describe the issue(s) fixed.

Replaces the somewhat big hardcode in ControlsMenu with softcode. For comparison, this is how the game handles the name of the headers currently:
image
(insert that one yanderedev tweet)

Tiny Issue

The header for Note controls is now named "Note" instead of "Notes" - to fix it I would have to change the names of the values for the enum Control, which would break a lot of things, or to add a hardcode for this scenario which I was trying to avoid this entire time

@github-actions github-actions bot added medium A medium pull request with 100 or fewer changes haxe Issue/PR modifies game code labels Dec 1, 2024
@charlesisfeline
Copy link

well it got rid of the headers

huh

@KoloInDaCrib
Copy link
Contributor Author

KoloInDaCrib commented Dec 1, 2024

Honestly surprising to me because I had ran a test mere moments before making a pr, I guess I'll draft it for now

Thank you for letting me know though

Edit: ran a test again and it works perfectly fine, not sure how it caused headers to disappear

@KoloInDaCrib KoloInDaCrib marked this pull request as draft December 1, 2024 20:37
@KoloInDaCrib KoloInDaCrib marked this pull request as ready for review December 1, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
haxe Issue/PR modifies game code medium A medium pull request with 100 or fewer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants