Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from source causes the URL:MAGNET protocol on Windows to be replaced and unchangable #137

Open
minhngoc25a opened this issue Mar 15, 2024 · 2 comments

Comments

@minhngoc25a
Copy link

Describe the bug
This bug only affects power users who want to build PikaTorrent from source. It doesn't affect normal users using the stable build. After running the build commands for PikaTorrent, the URL:MAGNET protocol on Windows will be set to whenever PikaTorrent's executable is after being built.

To Reproduce
Steps to reproduce the behaviour: (assuming beforehand we had qBittorrent as the default application to process magnet links)
Step 1: Clone PikaTorrent's source code
Step 2: Run the build commands

npm run web # To Start the web server
npm run desktop # To start the electron app

Step 3: The URL:MAGNET protocol is modified, and now by default, PikaTorrent's development executable will handle it instead. Since PikaTorrent also has a Microsoft Store build, this might be the reason why, after the protocol is modified, we can only select Microsoft Store apps to handle magnet links (see picture below).

Expected behaviour
The default app selector should be able to select any type of app, not just limited to Microsoft Store apps but external applications as well.

Screenshots
image

Platform:
Windows

@G-Ray
Copy link
Owner

G-Ray commented Mar 17, 2024

So if I understand correctly, PikaTorrent should set itself as the default magnet link handler only in production mode, and not in development, right ? I agree with this 💯

@minhngoc25a
Copy link
Author

Yes. The only way I was able to remove that was to install the production PikaTorrent, then uninstall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants