Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

各個 UI 元件應該有選擇性的 id #650

Open
caasi opened this issue May 18, 2020 · 3 comments
Open

各個 UI 元件應該有選擇性的 id #650

caasi opened this issue May 18, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@caasi
Copy link
Contributor

caasi commented May 18, 2020

Describe the solution you'd like
現在 UI 元件有 className 如果能有選擇性的 id 會更好。

Additional context
原生的 React UI 元件通常會有 id, classNamechildren

@caasi caasi added the enhancement New feature or request label May 18, 2020
@0xycvv
Copy link
Member

0xycvv commented May 26, 2020

應該已經可以把id props pass 下去了
what else do we need?

@caasi
Copy link
Contributor Author

caasi commented May 26, 2020

@0xycvv
Copy link
Member

0xycvv commented May 26, 2020

如果是 extends from BoxProps or straight from sc I think it should be fine
有些舊的component: Menu.. 要改一下props types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants