Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an AST to support or conditions in $filter #5

Open
Sjustein opened this issue May 6, 2024 · 0 comments
Open

Implement an AST to support or conditions in $filter #5

Sjustein opened this issue May 6, 2024 · 0 comments
Labels
low priority This is an issue that will not be picked up immediately and has little priority

Comments

@Sjustein
Copy link
Collaborator

Sjustein commented May 6, 2024

Implement an AST or some kind of lexer to more easily parse complex strings like the filter part of the odata query. To scope this issue a bit, only parse the currently supported grammar, but add support for and and or. Nesting statements should be left to future issues.

Acceptance criteria:

  • An AST is used to parse the filter part of the odata query instead of the current regex.
  • If it is determined implementing the AST has benefits for orderBy as well, implement it and support the choice in the PR.
  • The AST parses the filter string exactly the same way as the current regex, apart from also supporting and and or.
  • Tests are written to properly test the AST and the pipeline passes.
@Sjustein Sjustein added the low priority This is an issue that will not be picked up immediately and has little priority label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority This is an issue that will not be picked up immediately and has little priority
Projects
None yet
Development

No branches or pull requests

1 participant