Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godex crashes when closing the editor #218

Open
AndreaCatania opened this issue Jul 21, 2021 · 0 comments
Open

Godex crashes when closing the editor #218

AndreaCatania opened this issue Jul 21, 2021 · 0 comments
Assignees

Comments

@AndreaCatania
Copy link
Member

The crash is caused because the ScriptInstances inside ScriptEcs are cleared when the function unregister_modules_types is execute https://github.com/GodotECS/godex/blob/main/modules/godot/register_types.cpp#L156

However, at that time the scripts are already cleared out, and this cause a segmentation fault when the function _predelete is executed.

To fix this issue, it's necessary to clear the ScriptECS during the cleanup. This godot PR introduces a mechanism to get such callback: godotengine/godot#50179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant