feat: support esp-idf #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrKoR
reviewed
Oct 25, 2024
|
Could you please split this commit into two different commits?
|
itay-sho
force-pushed
the
feature/support-esp-idf
branch
from
f08a4df
to
1c6575a
Compare
required due to the fact that esp32-c6 compiler raises errors due to that
|
Hey, |
GrKoR
approved these changes
Oct 26, 2024
|
@itay-sho Hey, Itay! |
|
@itay-sho thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the dependency in Arduino.h which was used only for debugging.
fixing some wrong types that made compilation problems in my esp32-c6 - probably due to a newer compiler.
note: this is kind of hacky, but I managed to compile it.
might need some more effort to make sure that it works now both on older esp32 and newer ones, and maybe having a "real" F macro.