Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Explore using GraphQL Ruby's client directives #152

Open
daemonsy opened this issue Jan 25, 2022 · 2 comments
Open

feat: Explore using GraphQL Ruby's client directives #152

daemonsy opened this issue Jan 25, 2022 · 2 comments

Comments

@daemonsy
Copy link
Contributor

GraphQL Ruby has support for client directives now. It could potentially reduce the surface area of this library by quite a bit.

We have quite a bit code that seems to be responsible for generating the SDL.

@flvrone
Copy link

flvrone commented Feb 14, 2022

Hey @daemonsy! 👋
How about just adding the support for directives, without thinning out the gem's codebase for now? :)
I assume it should be simple. 🤔

@daemonsy
Copy link
Contributor Author

Yea that was what I was thinking in my spike. We could detect that native directives are supported and call a branch of code.

It wasn't hard, it just produced slightly different results (e.g. definitions of the directives itself) that caused the tests to fail.

I think the old code can be removed when GraphQL 1.13.x and 2.0.x are the dominant versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants