Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable formatting and/or linting and enforce good coding style #271

Open
johpiip opened this issue Mar 15, 2021 · 0 comments
Open

Enable formatting and/or linting and enforce good coding style #271

johpiip opened this issue Mar 15, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@johpiip
Copy link
Contributor

johpiip commented Mar 15, 2021

As discussed in #269, pylint is imported but not used. Here are steps to solve this:

  • Look into tools to enforce good coding style
  • Fix pylint messages
    • Documentation here: https://pylint.pycqa.org/en/1.9/technical_reference/features.html
    • Look into automated solutions for warnings regarding dull things like whitespaces
    • It may be beneficial to fix one message, report, category, or checker at a time. For example, the following throws only trailing-whitespace warnings: pipenv run python -m pylint --disable=all --enable=trailing-whitespace ..\Scripts\ This way the commits stay more informative.
  • Could Travis throw a warning for unaccepted coding style?
@johpiip johpiip self-assigned this Mar 15, 2021
@johpiip johpiip changed the title Enable linting Enable formatting and/or linting and enforce good coding style Mar 15, 2021
@zptro zptro added this to the v4.0.5 milestone Apr 8, 2021
@zptro zptro added the enhancement New feature or request label Apr 28, 2021
@zptro zptro modified the milestones: v4.0.5, v4.1 Jun 28, 2021
@zptro zptro removed this from the v4.1 milestone Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants