Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoutePath save bug when having old routePath opened in tab and using that when saving #1899

Open
Divinare opened this issue Apr 8, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Divinare
Copy link
Contributor

Divinare commented Apr 8, 2021

Backend PR: https://gitlab.hsl.fi/jore/jore-map-backend/-/merge_requests/346

Steps:

  1. Open the same routePath twice in 2 browser tabs
  2. Save routePath in one tab
  3. Save routePath again (without pressing f5) in other tab
  4. Now routePath geometries are broken
    --> Reason: it saves both and geometry validation doesn't compare situation after save 1 to changes of save 2

How to fix?
Before saving, in addition to checking if routePaths are sync, check that the routePath sent is in sync with the routePath found in local DB. For example you can compare the edit timestamp of local db routePath & routePath being saved.

@Divinare Divinare added the bug Something isn't working label Apr 8, 2021
@Divinare Divinare self-assigned this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant